Mobt 496 enforce forecast between references #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. Update CLI (still issues with this which will require further changes). Add new acceptance test.
…with CLI changes. Changes to unit tests to work with plugin changes. Update checksums.
Codecov Report
@@ Coverage Diff @@
## master #1907 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 120 120
Lines 11380 11410 +30
=======================================
+ Hits 11190 11220 +30
Misses 190 190
|
Katie-Howard
requested changes
Jun 6, 2023
There was a problem hiding this comment.
I've had a look through these changes, and they generally look fine. I just have one question to be addressed. I've also had a little look at the acceptance test data and left a comment on that too. I couldn't see any data in the new file, so if you could check that please?
Katie-Howard
previously approved these changes
Jun 7, 2023
mspelman07
requested changes
Jun 13, 2023
…sion, removed vestigial CLI.
mspelman07
requested changes
Jun 15, 2023
mspelman07
approved these changes
Jun 19, 2023
bayliffe
added a commit
to bayliffe/improver
that referenced
this pull request
Jul 28, 2023
* upstream/master: Fix to the wind vertical displacement adjustment implementation (metoppv#1927) Add function which normalises input cubes according to a reference (metoppv#1919) Skip ECC bounds usage when converting probabilities to percentiles (metoppv#1926) Add CLIs to support rescaling of the forecast based on altitude difference (metoppv#1917) Changes to the modal code to increase the percentage to 30% and change the groupings to provide a more representative daily summary symbol. (metoppv#1925) Add plugins to support rescaling of the forecast based on altitude difference (metoppv#1916) Support conversion from percentiles to probabilities (metoppv#1924) Correct handling of reference time in weather_code plugin (metoppv#1920) Add CLI for clipping cubes (metoppv#1918) Update cbh ecc name (metoppv#1922) Updates Broadcast and expand_bounds in Combine Plugin (metoppv#1914) Mobt515 cloud base height spot extraction (metoppv#1911) MOBT-494: Cube title setting in weather symbol code (metoppv#1912) MOBT512-masking percentiles for cloud base height (metoppv#1908) Mobt 496 enforce forecast between references (metoppv#1907)
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
* Extend plugin functionality to enable using two bounds. Add unit tests. Update CLI (still issues with this which will require further changes). Add new acceptance test. * Changes to CLI and acceptance test inputs. Changes to plugin to work with CLI changes. Changes to unit tests to work with plugin changes. Update checksums. * Update formatting. * Update formatting. * Update formatting. * Update docstring formatting. * remove whitespace. * Add acceptance test for non-matching input lengths. * Add new acceptance test for if inputs are too long. * Changes following review: Additions to docstring, updated unit conversion, removed vestigial CLI. * Changes following review: updated docstrings. * Changes following review: correct typo in docstring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1900
Acceptance test data: metoppv/improver_test_data#12
Adds functionality to enforce forecast to be within lower and upper bounds derived from linear functions of a reference forecast. This extends functionality implemented in #1900 .
Testing: