Update cbh ecc name #1922
Merged
Update cbh ecc name #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1922 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 121 121
Lines 11480 11480
=======================================
Hits 11290 11290
Misses 190 190
|
Katie-Howard
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
I've looked through the changes, and can see that it is just a change from "altitude" to "height", which is correct. The new acceptance tests data shows these changes too, and the cli tests run fine with the new data as well. I'm happy that this is all correct.
bayliffe
approved these changes
Jul 6, 2023
bayliffe
added a commit
to bayliffe/improver
that referenced
this pull request
Jul 28, 2023
* upstream/master: Fix to the wind vertical displacement adjustment implementation (metoppv#1927) Add function which normalises input cubes according to a reference (metoppv#1919) Skip ECC bounds usage when converting probabilities to percentiles (metoppv#1926) Add CLIs to support rescaling of the forecast based on altitude difference (metoppv#1917) Changes to the modal code to increase the percentage to 30% and change the groupings to provide a more representative daily summary symbol. (metoppv#1925) Add plugins to support rescaling of the forecast based on altitude difference (metoppv#1916) Support conversion from percentiles to probabilities (metoppv#1924) Correct handling of reference time in weather_code plugin (metoppv#1920) Add CLI for clipping cubes (metoppv#1918) Update cbh ecc name (metoppv#1922) Updates Broadcast and expand_bounds in Combine Plugin (metoppv#1914) Mobt515 cloud base height spot extraction (metoppv#1911) MOBT-494: Cube title setting in weather symbol code (metoppv#1912) MOBT512-masking percentiles for cloud base height (metoppv#1908) Mobt 496 enforce forecast between references (metoppv#1907)
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
* Updates ECC bound name for cloud base * update checksums --------- Co-authored-by: Marcus Spelman <marcus.spelman@metoffice.gov.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance test data: metoppv/improver_test_data#19
Updates ECC name of cloud base altitude to cloud base height as this diagnostic will be a height by the time it is converted to a percentile. This also requires the updating of cube names for a few tests
Testing: