Fix to the wind vertical displacement adjustment implementation #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… up 00Z for 23Z within a 1-hour leniency.
bayliffe
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1927 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 122 122
Lines 11707 11707
=======================================
Hits 11517 11517
Misses 190 190
|
Katie-Howard
previously approved these changes
Jul 20, 2023
brhooper
requested changes
Jul 20, 2023
| @@ -121,7 +121,7 @@ def _create_scaling_factor_cube( | |||
| Scaling factor cube. | |||
| """ | |||
| cubelist = iris.cube.CubeList() | |||
| for ref_hour in [3, 9]: | |||
| for ref_hour in [3, 12]: | |||
There was a problem hiding this comment.
I think the docstring needs updating to reflect this change
…fset of 0, is used before any other reference time is selected.
Katie-Howard
approved these changes
Jul 20, 2023
bayliffe
added a commit
to bayliffe/improver
that referenced
this pull request
Jul 28, 2023
* upstream/master: Fix to the wind vertical displacement adjustment implementation (metoppv#1927) Add function which normalises input cubes according to a reference (metoppv#1919) Skip ECC bounds usage when converting probabilities to percentiles (metoppv#1926) Add CLIs to support rescaling of the forecast based on altitude difference (metoppv#1917) Changes to the modal code to increase the percentage to 30% and change the groupings to provide a more representative daily summary symbol. (metoppv#1925) Add plugins to support rescaling of the forecast based on altitude difference (metoppv#1916) Support conversion from percentiles to probabilities (metoppv#1924) Correct handling of reference time in weather_code plugin (metoppv#1920) Add CLI for clipping cubes (metoppv#1918) Update cbh ecc name (metoppv#1922) Updates Broadcast and expand_bounds in Combine Plugin (metoppv#1914) Mobt515 cloud base height spot extraction (metoppv#1911) MOBT-494: Cube title setting in weather symbol code (metoppv#1912) MOBT512-masking percentiles for cloud base height (metoppv#1908) Mobt 496 enforce forecast between references (metoppv#1907)
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
…ppv#1927) * Ensure that the forecast reference time goes around the clock to pick up 00Z for 23Z within a 1-hour leniency. * Modify unit tests to require seeking for a match across the midnight divide. * Black formatting change. * Update test doc-string * Add an extra test to demonstrate that the exact reference time, an offset of 0, is used before any other reference time is selected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses an issue in the dz adjustment of wind speeds. The leniency applied for finding a dz adjustment match in the ancillary did not span across midnight, meaning a 23Z forecast reference time was unable to use a 00Z forecast reference time with a leniency of +- 1 hour. This change simply adds a modulus about 24 hours to ensure the looping around to 00Z occurs as required.
The unit tests have been modified to span the midnight line to check that this works as expected.
Testing: