Mobt515 cloud base height spot extraction #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 12, 2023 18:38
mspelman07
changed the title
added 3 commits
June 12, 2023 18:52
Codecov Report
@@ Coverage Diff @@
## master #1911 +/- ##
==========================================
+ Coverage 98.33% 98.34% +0.01%
==========================================
Files 120 121 +1
Lines 11390 11486 +96
==========================================
+ Hits 11200 11296 +96
Misses 190 190
|
brhooper
requested changes
Jun 14, 2023
There was a problem hiding this comment.
Thanks @mspelman07, this looks good, I've just left a couple of very minor comments.
| @cli.clizefy | ||
| @cli.with_output | ||
| def process( | ||
| spot_cube: cli.inputcube, neighbour: cli.inputcube, |
There was a problem hiding this comment.
Should neighbour_selection_method be made available as an input in the cli?
There was a problem hiding this comment.
Yes it should. I've updated the CLI to include this
| # Points outside the range of the original data return NAN. These points are replaced | ||
| # with the highest or lowest along the axis depending on the whether the vertical | ||
| # displacement was positive or negative | ||
| indicies = np.where(np.isnan(spot_data)) |
There was a problem hiding this comment.
Suggested change
| indicies = np.where(np.isnan(spot_data)) | |
| indices= np.where(np.isnan(spot_data)) |
Should also be changed in the next few lines as well
There was a problem hiding this comment.
Done. One day I'll learn how to spell indices.
brhooper
previously approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Thanks for making those changes @mspelman07, I'm happy with this now
gavinevans
requested changes
Jun 21, 2023
There was a problem hiding this comment.
Thanks for adding this functionality @mspelman07 👍
I've added some comments and queries.
gavinevans
requested changes
Jun 22, 2023
gavinevans
approved these changes
Jun 27, 2023
bayliffe
added a commit
to bayliffe/improver
that referenced
this pull request
Jul 28, 2023
* upstream/master: Fix to the wind vertical displacement adjustment implementation (metoppv#1927) Add function which normalises input cubes according to a reference (metoppv#1919) Skip ECC bounds usage when converting probabilities to percentiles (metoppv#1926) Add CLIs to support rescaling of the forecast based on altitude difference (metoppv#1917) Changes to the modal code to increase the percentage to 30% and change the groupings to provide a more representative daily summary symbol. (metoppv#1925) Add plugins to support rescaling of the forecast based on altitude difference (metoppv#1916) Support conversion from percentiles to probabilities (metoppv#1924) Correct handling of reference time in weather_code plugin (metoppv#1920) Add CLI for clipping cubes (metoppv#1918) Update cbh ecc name (metoppv#1922) Updates Broadcast and expand_bounds in Combine Plugin (metoppv#1914) Mobt515 cloud base height spot extraction (metoppv#1911) MOBT-494: Cube title setting in weather symbol code (metoppv#1912) MOBT512-masking percentiles for cloud base height (metoppv#1908) Mobt 496 enforce forecast between references (metoppv#1907)
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
* Adds plugin to adjust height above ground level forecasts and relevant tests * corrects handling of NAN data * formatting and removes un-needed test * formatting * formatting * update docstring * removes comment * add neighbour_selection_method to cli * correct spelling * formatting * changes following review * formatting * Updates following review comments --------- Co-authored-by: Marcus Spelman <marcus.spelman@metoffice.gov.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses metoppv/mo-blue-team#515
Acceptance_test_data PR: metoppv/improver_test_data#14
Adds an additional plugin and test that adjusts spot data to be relative to site altitude rather than grid square orography.
Testing: