Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobt 496 enforce forecast between references #12

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Mobt 496 enforce forecast between references #12

merged 2 commits into from
Jun 19, 2023

Conversation

brhooper
Copy link
Contributor

@brhooper brhooper commented Jun 2, 2023

Adds new kgo for acceptance test introduced in metoppv/improver#1907

@brhooper brhooper mentioned this pull request Jun 2, 2023
Merged
2 tasks
Katie-Howard
Katie-Howard requested changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@Katie-Howard Katie-Howard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes are just name changes, which should be fine. I've just the acceptance tests with the new acceptance test data and that all looks fine. However when I tried to look at the output for the new file (double_bound_percentile_kgo.nc) I couldn't see any data. I'm not sure whether it is something I've done, so could you check what it looks like for you?

@brhooper
Copy link
Contributor Author

brhooper commented Jun 6, 2023

Thanks for the review @Katie-Howard. Regarding your question, I seem to be able to see data in that kgo. I've plotted the double_bounds_percentile_kgo.nc and single_bounds_percentile_kgo.nc below, as well as the difference between them (which seems to be restricted to one site hidden in the Alps).

Double bounds:
image

SIngle bounds:
image

Difference:
image

Katie-Howard
Katie-Howard approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@Katie-Howard Katie-Howard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked through this and it all looks fine 👍

mspelman07
mspelman07 approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@mspelman07 mspelman07 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me.

@mspelman07 mspelman07 merged commit 2b5acfa into master Jun 19, 2023
Katie-Howard added a commit that referenced this pull request Jul 12, 2023
@Katie-Howard
Merge branch 'master' of github.com:metoppv/improver_test_data
2b779bf 
* 'master' of github.com:metoppv/improver_test_data:
  MOBT512- masking percentiles for cloud base height (#13)
  Mobt 496 enforce forecast between references (#12)
  Weather symbols output with manually set title attribute.
@bayliffe bayliffe deleted the mobt_496_enforce_forecast_between_references branch January 2, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Katie-Howard Katie-Howard Katie-Howard approved these changes

@mspelman07 mspelman07 mspelman07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brhooper @Katie-Howard @mspelman07