Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added audio column to GL & PreFare in admin table #1916

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

hannahpurcell
Copy link
Contributor

Adhoc, to make my life easier!

@cmaddox5 cmaddox5 assigned hannahpurcell and unassigned cmaddox5 Nov 7, 2023
Copy link

github-actions bot commented Nov 7, 2023

Coverage of commit 40256b4

Summary coverage rate:
  lines......: 39.3% (2159 of 5488 lines)
  functions..: 38.4% (873 of 2275 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@hannahpurcell hannahpurcell merged commit a486729 into master Nov 7, 2023
4 checks passed
@hannahpurcell hannahpurcell deleted the hp/add-audio-to-gl-admin-table branch November 7, 2023 21:36
cmaddox5 added a commit that referenced this pull request Nov 21, 2023
* Added departure_time in epoch seconds to response. (#1911)

* feature: New widget endpoint for einks (#1909)

* Pull last deploy timestamp from config cache, add to data response

* Removed unneeded ResponseMapper

* Added frontend for bus einks

* feat: OL Crowding Heuristics Implementation (#1879)

* Added translation to logger.

* Started on heuristics work.

* Changed what value is saved in Agent.

* Fixed logic for NB triptychs.

* Tweaked shutdown logic for accuracy logger.

* Removed inspect.

* Dialyzer.

* Changed heuristic to only log, not show widget.

* Changed time we use to determine heuristic.

* Changed variable name.

* Added an additional heuristic for consecutive crowding classes.

* Added nil check.

* Refactored heuristics so they run independently.

* Improved conditional.

* Added a log.

* Improved comments.

* Made hardcoded value a parameter.

* Changed log scenario name.

* Improved var name.

* Credo.

* Addressed comments.

* feat: Mercury GL E-Ink audio (#1913)

* Added audio SSML to screen data response on gl einks with audio configured.

* Updated screens_config.

* Tweaked data so we always include the key even if there is no audio.

* Added audio column to GL & PreFare in admin table (#1916)

* Add filter to make sure ID is a number. (#1915)

* fix: Skip CSRF protection on /widget POSTs since they really fetch a new HTML page (#1918)

* fix: Skip CSRF protection on /widget POSTs since they really fetch a new HTML page

* Build browser pipeline atop browser_no_csrf pipeline

* Added suppressions for GL Surge. (#1919)

* Added suppressions for GL Surge.

* Fixed Govt Ctr alert ids.

* Added a GL surge suppression at Kenmore.

* Alert ID fix.

---------

Co-authored-by: Hannah Purcell <69368883+hannahpurcell@users.noreply.github.com>
Co-authored-by: Jon Zimbel <63608771+jzimbel-mbta@users.noreply.github.com>
hannahpurcell added a commit that referenced this pull request Feb 2, 2024
* feat: Pre-Fare alerts 2.0 CandidateGenerator (#1765)

* [feature] Pre-fare alert 2.0 frontend left screen (#1787)

* feat: Pre-Fare alerts 2.0 serializer (#1785)

* feat: Disruption Diagram - Frontend (#1825)

* [tweak] Disruption diagram maths (#1830)

* In LocationContext, tag stop sequences by their routes (#1832)

* tweak: PreFare simulations (#1837)

* [feature] Prefare alerts 2.0 audio (#1824)

* feat: Disruption Diagram - Backend (#1828)

* feat(WIP): Disruption diagram backend. Working for Blue Line and other basic scenarios only atm.

* fix: Update location context stop sequences field in TrainCrowdingTest (#1895)

* test: D. diagram unit test for RL trunk statio closure with home stop at Ashmont (#1894)

* Added padding-top to layout when there is no banner. (#1902)

* Cm/govt ctr gl affected pill fix (#1898)

* Cm/adjust diagram size positioning (#1896)

* Changed label to display on a single line. (#1899)

* Tweaked resizer logic so it maxHeight matches the card height on page. (#1905)

* Removed bolding of 'to' from arrow labels. (#1908)

* Fixed icon display when current stop is affected. (#1903)

* feat: Consistent description of disrupted stop ranges throughout pre-fare alerts (#1912)

* Adjusted Ashmont/Braintree destination to proper formatting (#1917)

* Refactor disruption diagram SVG (#1914)

* Log alert ID and screen's home stop when disruption diagram logic fails (#1920)

* polish: Recalculate dimensions in hook (#1921)

* Added audio column to GL & PreFare in admin table (#1916)

* Draw D. diagrams for multi-line alerts when home stop narrows it to 1 line (#1922)

* fix: PreFare Polish - Inside shuttle (#1941)

* fix: Pre-fare polish - Boundary alerts banner (#1945)

* fix: Pre-fare polish -- Text only resizes for bypassed stations (#1946)

* fix: Pre-fare polish -- Station closed takeover text wrapping (#1947)

* Downstream shuttle endpoint should be a circle (#1948)

* Label splitting logic was buggy (#1949)

* Prefare format in config is "Ashmont & Braintree" not "Ashmont/Braintree" (#1954)

* Sub-header for takeover alert is now regular weight (#1955)

* fix: Prefare alerts polish -- Fix GL headsign in various cases (#1957)

* fix: Prefare polish -- Use FreeText to prevent station text wrapping in subheaders (#1956)

* fix: Prefare polish -- Alerts that break assumptions use the fallback case (#1958)

* fix: Prefare polish -- Reorder audio with alerts before subway status (#1962)

* fix: Prefare polish -- New abbreviation rule (#1961)

* fix: Prefare Alerts polish -- RL headsigns for branch-only alerts (#1967)

* fix: Prefare alerts polish -- Screenplay sim sizing / page layout (#1966)

* fix: Prefare polish -- "via" diagram labels need abbreviating (#1968)

---------

Co-authored-by: Christian Maddox <christian.maddox93@gmail.com>
Co-authored-by: Jon Zimbel <jzimbel@mbta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants