-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added suppressions for GL Surge. #1919
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaddox5
requested review from
a team and
hannahpurcell
and removed request for
a team
November 14, 2023 21:16
Coverage of commit
|
hannahpurcell
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Coverage of commit
|
Coverage of commit
|
jzimbel-mbta
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
cmaddox5
added a commit
that referenced
this pull request
Nov 21, 2023
* Added departure_time in epoch seconds to response. (#1911) * feature: New widget endpoint for einks (#1909) * Pull last deploy timestamp from config cache, add to data response * Removed unneeded ResponseMapper * Added frontend for bus einks * feat: OL Crowding Heuristics Implementation (#1879) * Added translation to logger. * Started on heuristics work. * Changed what value is saved in Agent. * Fixed logic for NB triptychs. * Tweaked shutdown logic for accuracy logger. * Removed inspect. * Dialyzer. * Changed heuristic to only log, not show widget. * Changed time we use to determine heuristic. * Changed variable name. * Added an additional heuristic for consecutive crowding classes. * Added nil check. * Refactored heuristics so they run independently. * Improved conditional. * Added a log. * Improved comments. * Made hardcoded value a parameter. * Changed log scenario name. * Improved var name. * Credo. * Addressed comments. * feat: Mercury GL E-Ink audio (#1913) * Added audio SSML to screen data response on gl einks with audio configured. * Updated screens_config. * Tweaked data so we always include the key even if there is no audio. * Added audio column to GL & PreFare in admin table (#1916) * Add filter to make sure ID is a number. (#1915) * fix: Skip CSRF protection on /widget POSTs since they really fetch a new HTML page (#1918) * fix: Skip CSRF protection on /widget POSTs since they really fetch a new HTML page * Build browser pipeline atop browser_no_csrf pipeline * Added suppressions for GL Surge. (#1919) * Added suppressions for GL Surge. * Fixed Govt Ctr alert ids. * Added a GL surge suppression at Kenmore. * Alert ID fix. --------- Co-authored-by: Hannah Purcell <69368883+hannahpurcell@users.noreply.github.com> Co-authored-by: Jon Zimbel <63608771+jzimbel-mbta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana task: Screens behavior in preparation for the GL surge
Added Gov't Ctr suppressions for the GL surge. Will be replaced with a full screen image on the left.