Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added suppressions for GL Surge. #1919

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Conversation

cmaddox5
Copy link
Contributor

Asana task: Screens behavior in preparation for the GL surge

Added Gov't Ctr suppressions for the GL surge. Will be replaced with a full screen image on the left.

  • Tests added?

@cmaddox5 cmaddox5 requested review from a team and hannahpurcell and removed request for a team November 14, 2023 21:16
Copy link

Coverage of commit 2c6b462

Summary coverage rate:
  lines......: 39.3% (2159 of 5488 lines)
  functions..: 38.4% (873 of 2275 functions)
  branches...: no data found

Files changed coverage rate:
                                                                   |Lines       |Functions  |Branches    
  Filename                                                         |Rate     Num|Rate    Num|Rate     Num
  =======================================================================================================
  lib/screens/v2/widget_instance/reconstructed_alert.ex            |90.4%    166| 100%    22|    -      0

Download coverage report

Copy link
Contributor

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

Coverage of commit 6bc9070

Summary coverage rate:
  lines......: 39.4% (2165 of 5499 lines)
  functions..: 38.4% (874 of 2277 functions)
  branches...: no data found

Files changed coverage rate:
                                                                   |Lines       |Functions  |Branches    
  Filename                                                         |Rate     Num|Rate    Num|Rate     Num
  =======================================================================================================
  lib/screens/v2/candidate_generator/dup/alerts.ex                 |68.3%     63|68.8%    16|    -      0
  lib/screens/v2/widget_instance/reconstructed_alert.ex            |90.5%    168| 100%    22|    -      0

Download coverage report

Copy link

Coverage of commit 6bc9070

Summary coverage rate:
  lines......: 39.4% (2167 of 5501 lines)
  functions..: 38.4% (874 of 2277 functions)
  branches...: no data found

Files changed coverage rate:
                                                                   |Lines       |Functions  |Branches    
  Filename                                                         |Rate     Num|Rate    Num|Rate     Num
  =======================================================================================================
  lib/screens/v2/candidate_generator/dup/alerts.ex                 |69.2%     65|68.8%    16|    -      0
  lib/screens/v2/widget_instance/reconstructed_alert.ex            |90.5%    168| 100%    22|    -      0

Download coverage report

Copy link
Member

@jzimbel-mbta jzimbel-mbta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmaddox5 cmaddox5 merged commit f7a053c into master Nov 20, 2023
2 checks passed
@cmaddox5 cmaddox5 deleted the cm/gl-surge-govt-ctr-suppressions branch November 20, 2023 16:48
cmaddox5 added a commit that referenced this pull request Nov 21, 2023
* Added departure_time in epoch seconds to response. (#1911)

* feature: New widget endpoint for einks (#1909)

* Pull last deploy timestamp from config cache, add to data response

* Removed unneeded ResponseMapper

* Added frontend for bus einks

* feat: OL Crowding Heuristics Implementation (#1879)

* Added translation to logger.

* Started on heuristics work.

* Changed what value is saved in Agent.

* Fixed logic for NB triptychs.

* Tweaked shutdown logic for accuracy logger.

* Removed inspect.

* Dialyzer.

* Changed heuristic to only log, not show widget.

* Changed time we use to determine heuristic.

* Changed variable name.

* Added an additional heuristic for consecutive crowding classes.

* Added nil check.

* Refactored heuristics so they run independently.

* Improved conditional.

* Added a log.

* Improved comments.

* Made hardcoded value a parameter.

* Changed log scenario name.

* Improved var name.

* Credo.

* Addressed comments.

* feat: Mercury GL E-Ink audio (#1913)

* Added audio SSML to screen data response on gl einks with audio configured.

* Updated screens_config.

* Tweaked data so we always include the key even if there is no audio.

* Added audio column to GL & PreFare in admin table (#1916)

* Add filter to make sure ID is a number. (#1915)

* fix: Skip CSRF protection on /widget POSTs since they really fetch a new HTML page (#1918)

* fix: Skip CSRF protection on /widget POSTs since they really fetch a new HTML page

* Build browser pipeline atop browser_no_csrf pipeline

* Added suppressions for GL Surge. (#1919)

* Added suppressions for GL Surge.

* Fixed Govt Ctr alert ids.

* Added a GL surge suppression at Kenmore.

* Alert ID fix.

---------

Co-authored-by: Hannah Purcell <69368883+hannahpurcell@users.noreply.github.com>
Co-authored-by: Jon Zimbel <63608771+jzimbel-mbta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants