fix: Prefare alerts polish -- Screenplay sim sizing / page layout #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahpurcell
requested review from
a team and
jzimbel-mbta
and removed request for
a team
Coverage of commit
|
assets/src/components/v2/disruption_diagram/disruption_diagram.tsx
Outdated
Show resolved
Hide resolved
assets/src/components/v2/disruption_diagram/disruption_diagram.tsx
Outdated
Show resolved
Hide resolved
assets/src/components/v2/disruption_diagram/disruption_diagram.tsx
Outdated
Show resolved
Hide resolved
assets/src/components/v2/disruption_diagram/disruption_diagram.tsx
Outdated
Show resolved
Hide resolved
assets/src/components/v2/disruption_diagram/disruption_diagram.tsx
Outdated
Show resolved
Hide resolved
assets/src/components/v2/disruption_diagram/disruption_diagram.tsx
Outdated
Show resolved
Hide resolved
assets/src/components/v2/disruption_diagram/disruption_diagram.tsx
Outdated
Show resolved
Hide resolved
assets/src/components/v2/disruption_diagram/disruption_diagram.tsx
Outdated
Show resolved
Hide resolved
assets/src/components/v2/pre_fare/simulation_screen_container.tsx
Outdated
Show resolved
Hide resolved
assets/src/components/v2/disruption_diagram/disruption_diagram.tsx
Outdated
Show resolved
Hide resolved
Coverage of commit
|
Coverage of commit
|
jzimbel-mbta
approved these changes
Feb 1, 2024
assets/src/components/v2/disruption_diagram/disruption_diagram.tsx
Outdated
Show resolved
Hide resolved
assets/src/components/v2/disruption_diagram/disruption_diagram.tsx
Outdated
Show resolved
Hide resolved
assets/src/components/v2/disruption_diagram/disruption_diagram.tsx
Outdated
Show resolved
Hide resolved
….tsx Co-authored-by: Jon Zimbel <63608771+jzimbel-mbta@users.noreply.github.com>
….tsx Co-authored-by: Jon Zimbel <63608771+jzimbel-mbta@users.noreply.github.com>
….tsx Co-authored-by: Jon Zimbel <63608771+jzimbel-mbta@users.noreply.github.com>
Coverage of commit
|
Coverage of commit
|
Coverage of commit
|
hannahpurcell
added a commit
that referenced
this pull request
Feb 2, 2024
* feat: Pre-Fare alerts 2.0 CandidateGenerator (#1765) * [feature] Pre-fare alert 2.0 frontend left screen (#1787) * feat: Pre-Fare alerts 2.0 serializer (#1785) * feat: Disruption Diagram - Frontend (#1825) * [tweak] Disruption diagram maths (#1830) * In LocationContext, tag stop sequences by their routes (#1832) * tweak: PreFare simulations (#1837) * [feature] Prefare alerts 2.0 audio (#1824) * feat: Disruption Diagram - Backend (#1828) * feat(WIP): Disruption diagram backend. Working for Blue Line and other basic scenarios only atm. * fix: Update location context stop sequences field in TrainCrowdingTest (#1895) * test: D. diagram unit test for RL trunk statio closure with home stop at Ashmont (#1894) * Added padding-top to layout when there is no banner. (#1902) * Cm/govt ctr gl affected pill fix (#1898) * Cm/adjust diagram size positioning (#1896) * Changed label to display on a single line. (#1899) * Tweaked resizer logic so it maxHeight matches the card height on page. (#1905) * Removed bolding of 'to' from arrow labels. (#1908) * Fixed icon display when current stop is affected. (#1903) * feat: Consistent description of disrupted stop ranges throughout pre-fare alerts (#1912) * Adjusted Ashmont/Braintree destination to proper formatting (#1917) * Refactor disruption diagram SVG (#1914) * Log alert ID and screen's home stop when disruption diagram logic fails (#1920) * polish: Recalculate dimensions in hook (#1921) * Added audio column to GL & PreFare in admin table (#1916) * Draw D. diagrams for multi-line alerts when home stop narrows it to 1 line (#1922) * fix: PreFare Polish - Inside shuttle (#1941) * fix: Pre-fare polish - Boundary alerts banner (#1945) * fix: Pre-fare polish -- Text only resizes for bypassed stations (#1946) * fix: Pre-fare polish -- Station closed takeover text wrapping (#1947) * Downstream shuttle endpoint should be a circle (#1948) * Label splitting logic was buggy (#1949) * Prefare format in config is "Ashmont & Braintree" not "Ashmont/Braintree" (#1954) * Sub-header for takeover alert is now regular weight (#1955) * fix: Prefare alerts polish -- Fix GL headsign in various cases (#1957) * fix: Prefare polish -- Use FreeText to prevent station text wrapping in subheaders (#1956) * fix: Prefare polish -- Alerts that break assumptions use the fallback case (#1958) * fix: Prefare polish -- Reorder audio with alerts before subway status (#1962) * fix: Prefare polish -- New abbreviation rule (#1961) * fix: Prefare Alerts polish -- RL headsigns for branch-only alerts (#1967) * fix: Prefare alerts polish -- Screenplay sim sizing / page layout (#1966) * fix: Prefare polish -- "via" diagram labels need abbreviating (#1968) --------- Co-authored-by: Christian Maddox <christian.maddox93@gmail.com> Co-authored-by: Jon Zimbel <jzimbel@mbta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[No task]
Gosh this was a wonky thing to fix. It was most complex in situations where there were two diagrams in the simulation for multiple disruption pages. I tried to clear things up with comments, but now the file is so so full of comments that it might be a bit overzealous. Let me know what you think!