polish: Recalculate dimensions in hook #1921
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana task: ad-hoc
For some reason, Firefox is consistently leaving
isDone
asfalse
. This means that thevisibility
on the svg stayshidden
even after resizing is done. I think this is because Firefox needs updated dimensions each time the hook executes. After making this change, FF is now flippingisDone
after resizing work is complete.**This PR seems much bigger than it is because of formatting. The only change that was made to logic is in commit
a1390ee9beaa78b8df2fc919507f5877c3c07df9
. The second commit only includes formatting changes.