Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.107.0 - staging → master #9898

Merged
merged 45 commits into from
Nov 13, 2023
Merged

Release v1.107.0 - staging → master #9898

merged 45 commits into from
Nov 13, 2023

Conversation

abailly-akamai
Copy link
Contributor

Cloud Manager

[2023-11-13] - v1.107.0

Changed:

  • Logic governing inclusion of public interfaces in Linode Create payload (#9834)
  • Improve layout of breadcrumb for support tickets (#9855)
  • Logic governing display of Network Interfaces/Networking section in Linode Config dialog (#9868)
  • Temporarily remove region sorting on DBaaS landing page (#9861)

Fixed:

  • Linodes Landing flickering (#9836)
  • Faux-bold font rendering (#9843)
  • Incorrect docs links for Main Concept and Simplex Marketplace apps (#9854)
  • Select Backup grid layout (#9862)

Tech Stories:

  • Tag Component v7 story migration (#9840)
  • BetaChip Component v7 story migration (#9864)
  • MUI Migration - SRC > Components > Crumbs (#9841)
  • Clean up app entrypoint render logic (#9844)
  • Fix Safari LaunchDarkly MSW Errors (#9863)

Tests:

  • Add DBaaS test coverage for disk metrics (#9833)
  • Improve Cypress rescue and rebuild test stability (#9867)
  • Upgrade Cypress to v13.x (#9874)
  • Add integration tests for AGLB certificate edit flow (#9880)
  • Add integration tests for AGLB certificate delete flow (#9846)

Upcoming Features:

  • Fix Unassign multiple Linodes from Subnet (#9820)
  • RemovableSelectionsList default maximum height and overflow scroll (#9827)
  • VPC UX feedback (#9832)
  • Remove temporary code for surfacing VPC interface errors and fix formatting of error in Linode Config dialog (#9839)
  • Refine payload in subnet "Assign Linodes" drawer (#9845)
  • Add Create VPC drawer to Linode Create flow and update Create Firewall button width (#9847)
  • Only unassign linodes in the 'Linodes to be Unassigned from Subnet' list for Subnet Unassign Drawer (#9851)
  • Clear subnet errors in Linode Create flow and VPC label errors in VPC Edit flow upon input change (#9857)
  • Fix IPv4 checkboxes for VPC interfaces in Linode Config dialog (#9865)
  • Fix incorrectly displayed error text in Linode Edit/Add config flow and prevent subnet section from incorrectly clearing in Linode Edit/Add Config and Linode Create flow (#9866)
  • Linode Details: VPC Subnets Not Associated with VPC IP Address Are Displayed (#9872)
  • Add VPC BETA Feedback link to VPC landing and detail pages (#9879)
  • Add dcGetWell feature flag (#9859)
  • Add RQ queries and mock data for DC Get Well (#9860)
  • Add RQ queries and mock data for Sold Out Plans (#9878)
  • Add basic AGLB create page and feature flag (#9856)
  • Add AGLB create page with Actions buttons (#9825)
  • Manage state in Create Load Balancer flow (#9848)
  • AGLB Configurations Add Route Drawer and other refinements (#9853)
  • Add missing label field validation in AGLB Edit Certificate drawer (#9880)

API-v4

[2023-11-13] - v0.105.0

Upcoming Features:

  • Add UpdateConfigurationPayload for AGLB (#9853)
  • Add getAccountAvailabilities and getAccountAvailability methods for DC Get Well initiative (#9860)
  • Add getRegionAvailabilities and getRegionAvailability endpoints and related types for Sold Out Plans initiative (#9878)

Validation

[2023-11-13] - v0.35.0

Upcoming Features:

  • Add CreateLoadBalancerEndpointSchema, CreateLoadBalancerServiceTargetSchema, CreateLoadBalancerRuleSchema, ConfigurationSchema, and CreateLoadBalancerSchema for AGLB (#9848)
  • Add UpdateConfigurationSchema for AGLB (#9853)
  • Add missing label validation to UpdateCertificateSchema for AGLB (#9880)

bnussman-akamai and others added 30 commits October 25, 2023 18:59
* dont block children from rendering

* Added changeset: Linodes Landing flickering

* clean up more

* fix preference toggle

* comment and clean up types

* remove ambiguous test

* show children after inital fetches

* fix AuthenticationWrapper logic and test

* revert change

* removed unused state

* fix lish

* fix AuthenticationWrapper more

* fix flags flickering

* add some e2e coverage

* Update packages/manager/src/IdentifyUser.tsx

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
* feat: [M3-7288] - AGLB create page with Actions buttons.

* Add configuration header section

* Add Actions buttons

* Render Regions as per the mockup

* Added changeset: AGLB create page with Actions buttons.

* Unit test coverage for LoadBalancerLabel

* Unit test for LoadBalancerConfiguration

* Update packages/manager/src/features/LoadBalancers/LoadBalancerCreate/LoadBalancerRegions.tsx

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

* Update packages/manager/.changeset/pr-9825-upcoming-features-1698093221284.md

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

* PR - Feedback

* PR - feedback

* Update packages/manager/src/features/LoadBalancers/LoadBalancerCreate/LoadBalancerConfiguration.tsx

Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>

* Update packages/manager/src/features/LoadBalancers/LoadBalancerCreate/LoadBalancerRegions.tsx

Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>

* PR - Feedback

* Fix alignment for small screen

* Override breadcrumb label

* Fix tests

* Adjust actions buttons order for small screens.

* Update packages/manager/src/features/LoadBalancers/LoadBalancerCreate/LoadBalancerConfiguration.test.tsx

Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>

* Rename file name - LoadBalancerLabel

* simplify styles and use less grid

* Wrap stepper component for mobile view

* add real regions

* Use util - convertToKebabCase

---------

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
Co-authored-by: Banks Nussman <banks@nussman.us>
…ight to cut off the last list item (#9827)

* update removable list height to cut off last item if scrolling is necessary

* add changeset

* box shadow for removable selections list

* fix safari box shadow display (css really really got me ;-;)

* cleanup, make dropshadow appear more dynamically
## Description 📝
Fix bug where selecting a single Linode in the Unassign Linodes drawer visually selects everything in the dropdown

## How to test 🧪

### Prerequisites
- Point to the dev env and ensure your account has vpc customer tags

### Reproduction steps
- Ensure you are on the develop branch or the remote dev environment
- Create a VPC and Subnet if you don't already have one
- Go to the VPC's details page and assign some Linodes to the Subnet via the kebab action menu in the table
- Click on Unassign Linodes via the kebab action menu and try to select a Linode
  - You should see that all Linodes are visually selected instead of just the one

### Verification steps 
- Confirm that you are able to select Linodes as normal and then click Unassign Linodes
- Confirm that the Subnet table removes the unassigned Linodes
- Confirm that the inline singular Unassign Linode still works as expected

---------

Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
…I. (#9833)

* Adding test coverage for disk metrics added to UI

* Add changeset

---------

Co-authored-by: Joe D'Amore <jdamore@linode.com>
)

* run tss migration and find and replace import

* fix breadcrumb story

* Added changeset: MUI Migration - SRC > Components > Crumbs

* remove outdated docs and feedback

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…#9832)

## Description 📝
Address UX feedback for VPC

## Changes  🔄
- Updated VPC empty landing text
- New VPC icon
- Minor UI changes to Assign Linode to Subnet drawer
- Updated tooltip text for the Auto-assign a VPC IPv4 address checkbox
- Minor text UI changes to VPC details page

## How to test 🧪

### Prerequisites
- Point to the dev env and ensure your account has vpc customer tags

### Verification steps 
Verify the ticket changes requested and check these flows:
- VPC empty landing (set line 87 to true in `VPCLanding`)
- VPC side menu and create menu icons
- Assign Linode to Subnet drawer
- VPC details page (changes are more noticeable in Safari)
…ed from Subnet' list for Subnet Unassign Drawer (#9851)

* bug fix

* remove duplicate logic that i previously added

* changeset

* update changeset

* recategorize changeset as upcoming features
Merge pull request #9852 from linode/master
* Tag v7 story & cleanup

* cleanup

* Added changeset: Tag Component v7 Story

* Feedback
* fix:[oca-1229] correct links to main concept docs

* fix:[oca-1129] correct simplex doc hyperlink

* adds changeset

* lint changeset formatting

* Update packages/manager/.changeset/pr-9854-fixed.md

Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>

* remove changeset formatting

* Fix changeset

* Make changeset description better

---------

Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
Co-authored-by: mjac0bs <mjacobs@akamai.com>
* add basic aglb create flow

* add changeset

* feedback

* add missing invalidation

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…low (#9821)

* M3-7189 Add assertions for backup prices in Linode Create flow

* Fixed comments
* Add dcGetWell flag

* Added changeset: Add dcGetWell featureflag

* Update packages/manager/.changeset/pr-9859-upcoming-features-1698850082776.md

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

---------

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
…9860)

* endpoints and endpoint types for dc get well

* dc get well react query

* mock data

* update endpoint oops

* changesets

* fix mock data

* update to region capabilities

* Update packages/manager/.changeset/pr-9860-upcoming-features-1698852576816.md

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

* Update packages/api-v4/.changeset/pr-9860-upcoming-features-1698852464578.md

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

---------

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
…and render tree logic (#9844)

* initial working

* more fixes

* fixes to auth flow

* why default to null?

* clean up splash screen styles

* clean up

* simplify things more

* rename files

* Added changeset: Clean up app entrypoint render logic

* improve useEffect logic

* clean up / feeback

* feedback and clean up

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
* Typography fontWeight

* eslint plugin

* eslint plugin improvement

* eslint plugin improvement

* organize local rules

* replace usage of fontWeight

* update snapshot and other fixes

* Revert typography change and lint for props

* Update snapshot

* Update markup in linode summary

* Added changeset: Faux-bold font rendering

* Convert plusing to TS

* Convert plusing to TS

* Update deps

* Move to external dependency

* update package
* Grid fix and cleanup

* Added changeset: Select backup grid layout

* Feedback
* feat: [M3-7311] - Create Load Balancer flow - Mange state.

* Code cleanup

* Added changeset: Create Load Balancer flow - Mange state.

* Update pr-9848-upcoming-features-1698675578462.md

* Update update-database.spec.ts

* Update packages/manager/.changeset/pr-9848-upcoming-features-1698675578462.md

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

* Fix typos

* use useFormikContext instead of custom state management hook

* PR feedback

* Update loadbalancers.schema.ts

* Update packages/validation/src/loadbalancers.schema.ts

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

* Update packages/validation/src/loadbalancers.schema.ts

Co-authored-by: jdamore-linode <97627410+jdamore-linode@users.noreply.github.com>

* Update loadbalancers.schema.ts

* Update CreateLoadBalancerSchema and Endpoint Schema

* Revert "Update CreateLoadBalancerSchema and Endpoint Schema"

This reverts commit 106f4d1.

* Code cleanup and update Endpoint schema.

* Update the field names

* Added changeset: Create Load Balancer flow - manage state

---------

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Co-authored-by: jdamore-linode <97627410+jdamore-linode@users.noreply.github.com>
…nements (#9853)

* fix up AGLB configurations

* various fixes

* add basic e2e test

* Added changeset: AGLB Configurations Add Route Drawer and other refinements

* improve mock data

* clean up and comment

* improve the mobile experence

* clean up regions

* fix create page crash

* feedback @mjac0bs

* Added changeset: AGLB Configurations Add Route Drawer and other refinements

* Added changeset: Add `UpdateConfigurationPayload`

* Added changeset: Add `UpdateConfigurationSchema` for AGLB

* Delete packages/manager/.changeset/pr-9853-upcoming-features-1698871857708.md

* add `id` to the routes table and add `id` to Load Balancer summary

* other minor improvements

* add certificate `id`

* export clean up and deep link configs

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
* Mock user preferences requests when testing Linode landing page summary view

* Refactor rebuild tests, improve flakiness by improving navigation flow

* Use new factory data for each request to prevent label conflicts

* Rename Linode utils

* Use mocks for rescue error test, wait for Linode to boot using UI rather than polling
…low (#9846)

* M3-7133 Add integration tests for AGLB certificate delete flow

* Add changeset
…flow and prevent clearing subnet section when clicking on currently assigned VPC (#9866)

* address bugs p1

* changeset

* fix bug p2

* update comments

* update changeset

* update tests

* change copy if no vpcs exist
## Description 📝
Clear VPC errors in the Linode Create and VPC Edit drawer flow after the input has changed

## How to test 🧪

### Prerequisites
- Point to the dev env and ensure your account has vpc customer tags
- Create two VPCs if you don't already have one

### Reproduction steps
Linode Create
- Be on the develop branch or go to the remote dev environment
- Go to `/linodes/create` and select a region and VPC, but not a subnet
- Click Create Linode and observe the "Subnet is required" error
- Select a Subnet, the error does not clear

VPC Edit
- Edit a VPC on the landing or details page
- Change the label to the same label as another VPC and click Save, you should see an error about unique labels
- Edit the label again, the error does not clear

### Verification steps 
Linode Create
- Go to `/linodes/create` and select a region and VPC, but not a subnet
- Click Create Linode and observe the "Subnet is required" error
- Select a Subnet, the error should clear

VPC Edit
- Edit a VPC on the landing or details page
- Change the label to the same label as another VPC and click Save, you should see an error about unique labels
- Edit the label again, the error should clear
* V7 story migration and cleanup

* add test

* revert unwanted change

* improve test

* Added changeset: BetaChip V7 story migration
…tus details (#9855)

* Initial UI change to match mockup

* Fix broken wrapping on mobile

* Update test

* Clean up and break into new component file

* Display all three ticket statuses

* Update test

* Fix console error from Typography

* Clean up Breadcrumb - remove subtitle

* Added changeset: Improve layout of breadcrumb for support tickets

* Improve test coverage

* Improve test coverage

* Update imports and address feedback - status color contrast

* Address feedback - clean up component render

* Add aria-label to status icon

* Update Storybook for StatusIcon
## Description 📝
Fix VPC IPv4 checkbox and input display when editing a config that already has ipv4 data

## Changes  🔄
1. The "Assign a public IPv4 address" checkbox is now checked in the Edit Config dialog upon opening if a VPC interface has already been 1:1 NAT’ed (i.e., if the `ipv4.nat_1_1` field is populated)
2. The "Auto-assign a VPC IPv4 address" is now unchecked in the Edit Config dialog if the `ipv4.vpc` field is already populated and we just expose the VPC IPv4 input field (pre-filled with the `ipv4.vpc` value)

## How to test 🧪

### Prerequisites
- Point to the dev env and ensure your account has vpc customer tags
- Create a VPC and Subnet if you don't already have one
- Click on Add Configuration in the Linode details -> Configuration tab
  - Provide a label and scroll down to the Networking section
  - Add a VPC, Subnet, and check both of the checkboxes

### Reproduction steps
- Be on the develop branch or go to the remote dev environment
- Filter your Network requests by `config` and notice how the `ipv4.vpc` and `ipv4.nat_1_1` fields of the interface are populated
- Click on Edit Configuration. The "Auto-assign a VPC IPv4 address" checkbox is checked and the VPC IPv4 input field is not exposed despite the field being populated. And the "Assign a public IPv4 address" checkbox is unchecked

### Verification steps 
- Filter your Network requests by `config` and notice how the `ipv4.vpc` and `ipv4.nat_1_1` fields of the interface are populated
- Click on Edit Configuration. The "Auto-assign a VPC IPv4 address" checkbox should be unchecked and the VPC IPv4 input field is now exposed and populated with the `ipv4.vpc` value. And the "Assign a public IPv4 address" checkbox is now checked
 ```
yarn test VPCPanel
```
bnussman-akamai and others added 15 commits November 6, 2023 14:42
… ending (#9876)

* use utc for unit test

* more strict assertion

* support est and edt

* fix comment

* improve mocks and tests

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
* fix safari launch darly

* remove broken mock data changer

* add changeset

* update the msw

* remove unneeded change

* fix a unit test

* fix more unit tests

* Update packages/manager/.changeset/pr-9863-tech-stories-1698862384325.md

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
…pdate widths for Create VPC and Create Firewall buttons (#9847)

* update api types and fix resulting errors

* add changesets

* increase timeout of specific test?

* Update packages/manager/.changeset/pr-9824-upcoming-features-1697827056392.md

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

* Update packages/api-v4/.changeset/pr-9824-upcoming-features-1697827003419.md

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

* address feedback for factories

* fix array size for subnet factories, update naming

* remove extra timeout

* fix cypress test: make mock subnet start with 0 linodes

* initial commit

* initial commit v2

* undo some changes, looking around

* need to fix styling and abstract everything but functionality exists

* fix VPCCreate styling as per ticket

* update spacing drawer

* create custom hook to abstract create VPC logic

* update custom useCreateVPC hook logic

* first of the form abstractions

* abstract form components

* styling of drawer

* changeset + some tests

* tests + update naming

* ensure that at least 1 subnet must be created for createVPC drawer

* some cleanup

* hide create link if vpc is not supported in region

* fix label that caused cypress failure

* address feedback p1

* feedback pt2

* small bit of cleanup

* Update packages/manager/src/features/VPCs/VPCCreate/SubnetNode.tsx

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

* feedback p1

* renamed file + updated imports

* update test comments

* remove bottom margin (see m3-7361)

* vpc panel unit tests

* Update pr-9847-upcoming-features-1698425054230.md

* fix: `ScheduleSettings.test.tsx` failing due to daylight savings time ending (#9876)

* use utc for unit test

* more strict assertion

* support est and edt

* fix comment

* improve mocks and tests

---------

Co-authored-by: Banks Nussman <banks@nussman.us>

* remove refetch on windows focus for vpc query

* update comment

---------

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
Co-authored-by: Banks Nussman <banks@nussman.us>
…old Out Plans (#9878)

* initial commit

* endpoints, types, react query queries, and mock data

* update mock

* changesets

* use getAll for availability query

* add small todo comment
…9861)

* fix [UIE-6977]: Remove region sort on DBaaS landing page

* TODO to add back sort once API is updated

* Added changeset: Remove region sorting on DBaaS landing page
#9872)

* feat: [M3-7399] - Linode Details - VPC Subnets Not Associated with VPC IP Address Are Displayed

* Added changeset: Linode Details: VPC Subnets Not Associated with VPC IP Address Are Displayed

* Update LinodeEntityDetail.tsx
…nconditionally & conditionally display "unavailable in region" helper text (#9868)
…it Certificate flow and improve form validation (#9880)

* WIP

* Add label validation to Edit Cert Drawer

* Add label validation check to test

* Clean up after rebase

* Add changesets

* Address feedback: scroll error into view

* Make Create drawer error handling and drawer width consistent

* Missed an import; fix failing typecheck
Release v1.107.0 - release → staging
@abailly-akamai abailly-akamai self-assigned this Nov 13, 2023
@abailly-akamai abailly-akamai marked this pull request as ready for review November 13, 2023 18:49
@abailly-akamai abailly-akamai requested a review from a team as a code owner November 13, 2023 18:49
Copy link

cypress bot commented Nov 13, 2023

1 flaky test on run #5389 ↗︎

0 259 0 0 Flakiness 1

Details:

Merge pull request #9889 from linode/release-v1.107.0
Project: Cloud Manager E2E Commit: 41356e500a
Status: Passed Duration: 15:22 💡
Started: Nov 13, 2023 6:39 PM Ended: Nov 13, 2023 6:54 PM
Flakiness  cypress/e2e/core/longview/longview.spec.ts • 1 flaky test

View
Output

Test Artifacts
longview > tests longview Screenshots

Review all test suite changes for PR #9898 ↗︎

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@abailly-akamai abailly-akamai merged commit 52246bf into master Nov 13, 2023
31 checks passed
@mjac0bs mjac0bs added the Release Cloud Manager releases label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Cloud Manager releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.