change: [M3-6522] - Tag Component v7 story & cleanup #9840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
commented
Oct 24, 2023
| type Variants = 'blue' | 'lightBlue'; | ||
|
|
||
| export interface TagProps extends ChipProps { | ||
| asSuggestion?: boolean; |
There was a problem hiding this comment.
This was only used as a boolean for closeMenu (in main search bar) so i took it out and checked for closeMenu directly
| } | ||
| history.push(`/search/?query=tag:${label}`); | ||
| }; | ||
|
|
||
| // If maxLength is set, truncate display to that length. | ||
| const _label = maxLength ? truncateEnd(label, maxLength) : label; | ||
|
|
||
| const tagProps = omit(props, ['asSuggestion', 'closeMenu']); |
There was a problem hiding this comment.
we can just use shouldForwardProps on the styled component for this
abailly-akamai
requested review from
bnussman-akamai and
cliu-akamai
and removed request for
a team
bnussman-akamai
approved these changes
Oct 25, 2023
abailly-akamai
force-pushed
the
M3-6522-tag
branch
from
a2b38d1
to
17d82f7
Compare
jdamore-linode
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Thanks @abailly-akamai! Changes look good in Storybook, and I'm always excited to see doc improvements and test additions
This was referenced Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR replaces the Tag component's
.mdxstory with a fresh v7 story.Changes 🔄
Broken hover state in main menu
Poor contrast & accessibility on dark mode
Preview 📷
Apart from the fixes shown above, there should be no change in the way the component looks or behaves.
How to test 🧪
Prerequisites
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply