feat: [M3-7209] – VPC BETA Feedback button #9879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocsLink.tsx so it is reusable for this use case; add constant for feedback URL; add icon & link to VPC Landing page
dwiley-akamai
requested review from
jaalah-akamai and
tyler-akamai
and removed request for
a team
|
Verified that the:
|
|
other than the merge conflict, LGTM 🚀 |
tyler-akamai
approved these changes
Nov 7, 2023
12 tasks
jaalah-akamai
approved these changes
Nov 8, 2023
This was referenced Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add a VPC BETA Feedback button to the VPC landing and detail pages.
Changes 🔄
iconprop added toDocsLink.tsxto make it reusable for this use case (instead of creating a separate component)Preview 📷
VPC Landing page
VPC Details page
How to test 🧪
Prerequisites
Verification steps
Go to the VPC landing and detail pages and confirm the
BETA Feedbackbutton displays with the appropriate icon and links to the feedback form.Confirm that the normal Docs links throughout the app have not been adversely impacted.
As an Author I have considered 🤔
Check all that apply