-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-7133] - Add integration tests for AGLB certificate delete flow #9846
Conversation
); | ||
}); | ||
|
||
it('can handle server errors gracefully when failing to delete the certificate', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this test, should we mock mockDeleteLoadBalancerCertificate
as a failure (and check for the error in the dialog) rather than mockGetLoadBalancerCertificates
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Will change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9779a96
to
944cf12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🎉 Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and runs great! Thanks Cassie!
@cliu-akamai Could we add a changeset with |
944cf12
to
ca18d98
Compare
Description 📝
Add new integration tests for Akamai Global Load Balancer certificate delete flow.
Major Changes 🔄
How to test 🧪