Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-7133] - Add integration tests for AGLB certificate delete flow #9846

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

cliu-akamai
Copy link
Contributor

Description 📝

Add new integration tests for Akamai Global Load Balancer certificate delete flow.

Major Changes 🔄

  • Add new cypress test cases to check deleting AGLB certificates.

How to test 🧪

yarn cy:run -s "cypress/e2e/core/loadBalancers/load-balancer-certificates.spec.ts"

@cliu-akamai cliu-akamai requested a review from a team as a code owner October 27, 2023 14:53
@cliu-akamai cliu-akamai requested review from hana-akamai and cpathipa and removed request for a team October 27, 2023 14:53
@cliu-akamai cliu-akamai self-assigned this Oct 27, 2023
@mjac0bs mjac0bs added the ACLB Relating to the Akamai Cloud Load Balancer label Oct 30, 2023
);
});

it('can handle server errors gracefully when failing to delete the certificate', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this test, should we mock mockDeleteLoadBalancerCertificate as a failure (and check for the error in the dialog) rather than mockGetLoadBalancerCertificates?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Will change it.

Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Was able to run the tests.
image

Agree with Banks feedback. Approving with pending changes.

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉 Thank you!

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and runs great! Thanks Cassie!

@mjac0bs
Copy link
Contributor

mjac0bs commented Nov 2, 2023

@cliu-akamai Could we add a changeset with yarn changeset, please? Other than that, looks like you're set!

@mjac0bs mjac0bs added Missing Changeset Approved Multiple approvals and ready to merge! labels Nov 2, 2023
@cliu-akamai cliu-akamai merged commit 4d25e1a into linode:develop Nov 3, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACLB Relating to the Akamai Cloud Load Balancer Approved Multiple approvals and ready to merge! Missing Changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants