Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-7189] - Add assertions for backup prices in Linode Create flow #9821

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

cliu-akamai
Copy link
Contributor

Description 📝

Add new cypress assertions for backup prices in Linode create flow.

Major Changes 🔄

  • Add new cypress assertions to check backup prices when creating a Linode.

How to test 🧪

yarn cy:run -s "cypress/e2e/core/linodes/create-linode.spec.ts"

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-10-23 at 09 46 59

Screenshot 2023-10-23 at 09 44 22

Am getting consistent failures on the "creates a linode via cli" step finding a region Id

@cliu-akamai
Copy link
Contributor Author

cliu-akamai commented Oct 26, 2023

Screenshot 2023-10-23 at 09 46 59

Screenshot 2023-10-23 at 09 44 22

Am getting consistent failures on the "creates a linode via cli" step finding a region Id

Hmm, that's strange. I didn't change anything in the creates a linode via cli test case. Is it because the token you used does not have access to region br-gru and us-iad?

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cliu-akamai - this passed consistently for me and I confirmed that I saw this test check for the expected DC-specific backup prices in the Addons and Summary sections.

Screenshot 2023-10-26 at 10 11 20 AM

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Oct 26, 2023
@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Oct 26, 2023
@mjac0bs
Copy link
Contributor

mjac0bs commented Oct 30, 2023

Thanks for addressing that small bit of feedback, @cliu-akamai! I reran the tests on this this morning because there were a bunch of failures on the run for some reason. The last finished run still has a few failed, unrelated tests for some reason (rebuild-linode.spec.ts,access-keys.smoke.spec.ts , object-storage.smoke.spec.ts ) but these all pass fine locally. These changes should be all set to merge. 🚢

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks @cliu-akamai

@cliu-akamai cliu-akamai merged commit 13ccb71 into linode:develop Nov 1, 2023
12 of 13 checks passed
@cliu-akamai cliu-akamai deleted the feature/M3-7189 branch November 1, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! DC-Specific Pricing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants