Set memory limits #921
Merged
Set memory limits #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/XS
grantr
reviewed
Mar 19, 2019
config/500-controller.yaml
Outdated
| @@ -52,6 +52,9 @@ spec: | |||
| ports: | |||
| - containerPort: 9090 | |||
| name: metrics | |||
| resources: | |||
| limits: | |||
| memory: 1000Mi | |||
There was a problem hiding this comment.
Can you add a comment explaining the provenance of this value? Even if it's just dart board, that gives the future maintainer context about how the value was derived and what would be required to improve on it.
There was a problem hiding this comment.
Done - see if my comment is sufficient.
We're seeing OOM issues at the Node level when we don't set the limit on some pods. This will allow the pod to restart gracefully w/o taking down the entire node. I'm not stuck on the specific value so we can pick a different one. See knative/serving#3332 for the serving equivalent. Signed-off-by: Doug Davis <dug@us.ibm.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: duglin, grantr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
@grantr done - let me know if I didn't do it correctly |
|
Looks good, thanks! |
slinkydeveloper
pushed a commit
to slinkydeveloper/eventing
that referenced
this pull request
Oct 28, 2020
* Flags to configure eventing upgrade tests forwarder (ksvc) (knative#3899) * Flags to configure eventing upgrade tests forwarder (ksvc) This change is required to complete knative/operator#252 It enables configuring of wathola forwarder implemented as Knative Service. Configuration is done by using new optional environment variables. * Using kelseyhightower/envconfig after code review * Docs for Eventing upgrade tests config overrides. * Eventing upgrade tests prober fully configurable Conflicts resolved: * test/upgrade/prober/configuration.go * test/upgrade/prober/forwarder.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing OOM issues at the Node level when we don't set the limit on some pods. This will allow the pod to restart gracefully w/o taking down the entire node.
I'm not stuck on the specific value so we can pick a different one.
See knative/serving#3332 for the serving equivalent.
Signed-off-by: Doug Davis dug@us.ibm.com
Release Note