Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibana-logging deployment is missing memory request/limit sizes #3333

Closed
kramvan1 opened this issue Feb 27, 2019 · 8 comments
Closed

Kibana-logging deployment is missing memory request/limit sizes #3333

kramvan1 opened this issue Feb 27, 2019 · 8 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@kramvan1
Copy link

In what area(s)?

/area monitoring

What version of Knative?

0.3.x
HEAD

Expected Behavior

All deployments of knative have request/limits for CPU and Memory.

Actual Behavior

https://github.com/knative/serving/blob/master/third_party/config/monitoring/logging/elasticsearch/kibana.yaml#L42-L46 is missing the memory side.

Steps to Reproduce the Problem

View the deployment yaml for kibana-logging

@kramvan1 kramvan1 added the kind/bug Categorizes issue or PR as related to a bug. label Feb 27, 2019
@kramvan1
Copy link
Author

cc @duglin

@duglin
Copy link

duglin commented Feb 27, 2019

Per @kramvan1 I need to also check:

  • zipkin
  • build-controller
  • build-webhook
  • eventing-controller
  • knative-eventing
  • knative-ingressgateway
  • prometheus-system

@duglin
Copy link

duglin commented Feb 27, 2019

PR for serving ones: #3332

@mdemirhan mdemirhan added this to the Serving 0.5 milestone Mar 11, 2019
@mattmoor
Copy link
Member

@duglin what's left here in Serving?

@duglin
Copy link

duglin commented Mar 19, 2019

Eventing one: knative/eventing#921

@duglin
Copy link

duglin commented Mar 19, 2019

For build: knative/build#572

@duglin
Copy link

duglin commented Mar 19, 2019

Istio one: istio/istio#12344

@duglin
Copy link

duglin commented Mar 19, 2019

Yes I think we can close this one since the serving side is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants