Skip to content

Commit

Permalink
Set memory limits (#921)
Browse files Browse the repository at this point in the history
We're seeing OOM issues at the Node level when we don't set the limit on some pods. This will allow the pod to restart gracefully w/o taking down the entire node.

I'm not stuck on the specific value so we can pick a different one.

See knative/serving#3332 for the serving equivalent.

Signed-off-by: Doug Davis <dug@us.ibm.com>
  • Loading branch information
Doug Davis authored and knative-prow-robot committed Mar 19, 2019
1 parent 7c13060 commit bab95e5
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions config/500-controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ spec:
ports:
- containerPort: 9090
name: metrics
resources:
limits:
memory: 1000Mi # An initial guess, but consistent with serving
volumeMounts:
- name: config-logging
mountPath: /etc/config-logging
Expand Down
3 changes: 3 additions & 0 deletions config/500-webhook.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ spec:
fieldPath: metadata.namespace
- name: CONFIG_LOGGING_NAME
value: config-logging
resources:
limits:
memory: 1000Mi # An initial guess, but consistent with serving
volumes:
- name: config-logging
configMap:
Expand Down

0 comments on commit bab95e5

Please sign in to comment.