Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flags to configure eventing upgrade tests forwarder (ksvc) #3899

Merged

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Aug 20, 2020

This change is required to complete knative/operator#252

It enables configuring of wathola forwarder implemented as Knative Service. Configuration is done by using new optional environment variables.

Proposed Changes

  • eventing upgrade tests configuration

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 20, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 20, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Aug 20, 2020
This change is required to complete knative/operator#252

It enables configuring of wathola forwarder implemented as Knative
Service. Configuration is done by using new optional environment
variables.
@cardil cardil force-pushed the bugfix/configurable-wathola-forwarder branch from 77551f6 to 2c2ec1e Compare August 20, 2020 20:49
@cardil cardil requested a review from vaikas August 21, 2020 18:07
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

@cardil cardil force-pushed the bugfix/configurable-wathola-forwarder branch from 17c42bc to c3b643b Compare August 24, 2020 20:00
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)

Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

@cardil cardil force-pushed the bugfix/configurable-wathola-forwarder branch from c3b643b to bbc054f Compare August 24, 2020 20:02
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)

@cardil cardil force-pushed the bugfix/configurable-wathola-forwarder branch from bbc054f to 4f4b5a3 Compare August 24, 2020 20:03
@cardil cardil requested a review from vaikas August 24, 2020 20:07
@cardil
Copy link
Contributor Author

cardil commented Aug 26, 2020

@vaikas does this look good to you now?

@vaikas
Copy link
Contributor

vaikas commented Aug 26, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2020
@knative-prow-robot knative-prow-robot merged commit 38b6ca1 into knative:master Aug 26, 2020
@cardil cardil deleted the bugfix/configurable-wathola-forwarder branch August 26, 2020 20:23
cardil added a commit to cardil/knative-eventing that referenced this pull request Oct 28, 2020
)

* Flags to configure eventing upgrade tests forwarder (ksvc)

This change is required to complete knative/operator#252

It enables configuring of wathola forwarder implemented as Knative
Service. Configuration is done by using new optional environment
variables.

* Using kelseyhightower/envconfig after code review

* Docs for Eventing upgrade tests config overrides.
openshift-merge-robot pushed a commit to openshift/knative-eventing that referenced this pull request Oct 28, 2020
* Flags to configure eventing upgrade tests forwarder (ksvc) (knative#3899)

* Flags to configure eventing upgrade tests forwarder (ksvc)

This change is required to complete knative/operator#252

It enables configuring of wathola forwarder implemented as Knative
Service. Configuration is done by using new optional environment
variables.

* Using kelseyhightower/envconfig after code review

* Docs for Eventing upgrade tests config overrides.

* Eventing upgrade tests prober fully configurable

Conflicts resolved:
 * test/upgrade/prober/configuration.go
 * test/upgrade/prober/forwarder.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants