-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flags to configure eventing upgrade tests forwarder (ksvc) #3899
Flags to configure eventing upgrade tests forwarder (ksvc) #3899
Conversation
This change is required to complete knative/operator#252 It enables configuring of wathola forwarder implemented as Knative Service. Configuration is done by using new optional environment variables.
77551f6
to
2c2ec1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)
17c42bc
to
c3b643b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)
c3b643b
to
bbc054f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)
bbc054f
to
4f4b5a3
Compare
@vaikas does this look good to you now? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
) * Flags to configure eventing upgrade tests forwarder (ksvc) This change is required to complete knative/operator#252 It enables configuring of wathola forwarder implemented as Knative Service. Configuration is done by using new optional environment variables. * Using kelseyhightower/envconfig after code review * Docs for Eventing upgrade tests config overrides.
* Flags to configure eventing upgrade tests forwarder (ksvc) (knative#3899) * Flags to configure eventing upgrade tests forwarder (ksvc) This change is required to complete knative/operator#252 It enables configuring of wathola forwarder implemented as Knative Service. Configuration is done by using new optional environment variables. * Using kelseyhightower/envconfig after code review * Docs for Eventing upgrade tests config overrides. * Eventing upgrade tests prober fully configurable Conflicts resolved: * test/upgrade/prober/configuration.go * test/upgrade/prober/forwarder.go
This change is required to complete knative/operator#252
It enables configuring of wathola forwarder implemented as Knative Service. Configuration is done by using new optional environment variables.
Proposed Changes