Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tests for Eventing should utilize Knative Serving forwarder component #252

Closed
cardil opened this issue Aug 20, 2020 · 2 comments · Fixed by #274
Closed

Upgrade tests for Eventing should utilize Knative Serving forwarder component #252

cardil opened this issue Aug 20, 2020 · 2 comments · Fixed by #274
Assignees

Comments

@cardil
Copy link
Contributor

cardil commented Aug 20, 2020

Eventing upgrade test has been written in a way that there is an optional forwarder component, that is implemented as Knative Service. See diagram at https://github.com/knative/eventing/tree/c8aa486/test/upgrade#probe-test. That was created in this way to test if there are no additional problems with cooperation between Serving and Eventing while upgrading or downgrading.

This repo installs Serving and Eventing, and so that let us utilize this interoop option.

Upgrade tests should be executed in a way that https://github.com/knative/eventing/blob/c8aa486/test/upgrade/prober/prober.go#L72 is set to true

/kind feature-request

@cardil cardil added the kind/bug Categorizes issue or PR as related to a bug. label Aug 20, 2020
@cardil
Copy link
Contributor Author

cardil commented Aug 20, 2020

/remove-kind bug

@knative-prow-robot knative-prow-robot removed the kind/bug Categorizes issue or PR as related to a bug. label Aug 20, 2020
@cardil
Copy link
Contributor Author

cardil commented Aug 20, 2020

/assign

cardil added a commit to cardil/knative-eventing that referenced this issue Aug 20, 2020
This change is required to complete knative/operator#252

It enables configuring of wathola forwarder implemented as Knative
Service. Configuration is done by using new optional environment
variables.
cardil added a commit to cardil/knative-eventing that referenced this issue Aug 20, 2020
This change is required to complete knative/operator#252

It enables configuring of wathola forwarder implemented as Knative
Service. Configuration is done by using new optional environment
variables.
knative-prow-robot pushed a commit to knative/eventing that referenced this issue Aug 26, 2020
* Flags to configure eventing upgrade tests forwarder (ksvc)

This change is required to complete knative/operator#252

It enables configuring of wathola forwarder implemented as Knative
Service. Configuration is done by using new optional environment
variables.

* Using kelseyhightower/envconfig after code review

* Docs for Eventing upgrade tests config overrides.
cardil added a commit to cardil/knative-eventing that referenced this issue Oct 28, 2020
)

* Flags to configure eventing upgrade tests forwarder (ksvc)

This change is required to complete knative/operator#252

It enables configuring of wathola forwarder implemented as Knative
Service. Configuration is done by using new optional environment
variables.

* Using kelseyhightower/envconfig after code review

* Docs for Eventing upgrade tests config overrides.
openshift-merge-robot pushed a commit to openshift/knative-eventing that referenced this issue Oct 28, 2020
* Flags to configure eventing upgrade tests forwarder (ksvc) (knative#3899)

* Flags to configure eventing upgrade tests forwarder (ksvc)

This change is required to complete knative/operator#252

It enables configuring of wathola forwarder implemented as Knative
Service. Configuration is done by using new optional environment
variables.

* Using kelseyhightower/envconfig after code review

* Docs for Eventing upgrade tests config overrides.

* Eventing upgrade tests prober fully configurable

Conflicts resolved:
 * test/upgrade/prober/configuration.go
 * test/upgrade/prober/forwarder.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants