Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eventing.yaml missing for 0.17 #3873

Closed
matzew opened this issue Aug 19, 2020 · 9 comments · Fixed by #3884
Closed

Eventing.yaml missing for 0.17 #3873

matzew opened this issue Aug 19, 2020 · 9 comments · Fixed by #3884
Assignees
@Harwayne
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@matzew
Copy link
Member

matzew commented Aug 19, 2020

Describe the bug

While the script still has it:
https://github.com/knative/eventing/blob/master/hack/release.sh#L33

we do not have a release asset eventing.yaml for our 0.17 release, see:

https://github.com/knative/eventing/releases

Expected behavior

a convenient eventing.yaml file is there for download
@matzew matzew added the kind/bug Categorizes issue or PR as related to a bug. label Aug 19, 2020
@lionelvillard
Copy link
Member

@Harwayne

@pierDipi pierDipi mentioned this issue Aug 19, 2020
Merged
@pierDipi
Copy link
Member

The upgrade test is failing because of the missing file.

@Harwayne Harwayne self-assigned this Aug 19, 2020
@Harwayne
Copy link
Contributor

This is the prow job that created the release.

I can see that it created the YAML file:

Assembling Knative Eventing - eventing.yaml

And then inspected it:

 Inspecting eventing.yaml
 Created [gcr.io/knative-releases/knative.dev/eventing/cmd/controller:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/controller@sha256:3df49b95f5dc475040898131e540e366d8d1d3c7053cfcbe41a51f92d1a858d0].
 Created [us.gcr.io/knative-releases/knative.dev/eventing/cmd/controller:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/controller@sha256:3df49b95f5dc475040898131e540e366d8d1d3c7053cfcbe41a51f92d1a858d0].
 Created [eu.gcr.io/knative-releases/knative.dev/eventing/cmd/controller:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/controller@sha256:3df49b95f5dc475040898131e540e366d8d1d3c7053cfcbe41a51f92d1a858d0].
 Created [asia.gcr.io/knative-releases/knative.dev/eventing/cmd/controller:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/controller@sha256:3df49b95f5dc475040898131e540e366d8d1d3c7053cfcbe41a51f92d1a858d0].
 Created [gcr.io/knative-releases/knative.dev/eventing/cmd/ping:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/ping@sha256:752c605f4ba0d5e3e011c994dbe3c0e1f5ba3d13950dc302ab861bf933c142e3].
 Created [us.gcr.io/knative-releases/knative.dev/eventing/cmd/ping:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/ping@sha256:752c605f4ba0d5e3e011c994dbe3c0e1f5ba3d13950dc302ab861bf933c142e3].
 Created [eu.gcr.io/knative-releases/knative.dev/eventing/cmd/ping:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/ping@sha256:752c605f4ba0d5e3e011c994dbe3c0e1f5ba3d13950dc302ab861bf933c142e3].
 Created [asia.gcr.io/knative-releases/knative.dev/eventing/cmd/ping:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/ping@sha256:752c605f4ba0d5e3e011c994dbe3c0e1f5ba3d13950dc302ab861bf933c142e3].
 Created [gcr.io/knative-releases/knative.dev/eventing/cmd/mtping:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/mtping@sha256:4c2c2f951f0253cf215cfc69956a12d7e7cecccc56c97f0dbebb735d96ca6360].
 Created [us.gcr.io/knative-releases/knative.dev/eventing/cmd/mtping:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/mtping@sha256:4c2c2f951f0253cf215cfc69956a12d7e7cecccc56c97f0dbebb735d96ca6360].
 Created [eu.gcr.io/knative-releases/knative.dev/eventing/cmd/mtping:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/mtping@sha256:4c2c2f951f0253cf215cfc69956a12d7e7cecccc56c97f0dbebb735d96ca6360].
 Created [asia.gcr.io/knative-releases/knative.dev/eventing/cmd/mtping:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/mtping@sha256:4c2c2f951f0253cf215cfc69956a12d7e7cecccc56c97f0dbebb735d96ca6360].
 Created [gcr.io/knative-releases/knative.dev/eventing/cmd/webhook:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/webhook@sha256:e0bba359e5bd05c074f3f1141d6fb72911d5629a61fe974e444e86b4b66e668c].
 Created [us.gcr.io/knative-releases/knative.dev/eventing/cmd/webhook:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/webhook@sha256:e0bba359e5bd05c074f3f1141d6fb72911d5629a61fe974e444e86b4b66e668c].
 Created [eu.gcr.io/knative-releases/knative.dev/eventing/cmd/webhook:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/webhook@sha256:e0bba359e5bd05c074f3f1141d6fb72911d5629a61fe974e444e86b4b66e668c].
 Created [asia.gcr.io/knative-releases/knative.dev/eventing/cmd/webhook:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/webhook@sha256:e0bba359e5bd05c074f3f1141d6fb72911d5629a61fe974e444e86b4b66e668c].
 Created [gcr.io/knative-releases/knative.dev/eventing/cmd/mtbroker/filter:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/mtbroker/filter@sha256:c3fcf096439ef7cd438b97f44e0318ca6d94b73c47953de768c92de584dbcd3c].
 Created [us.gcr.io/knative-releases/knative.dev/eventing/cmd/mtbroker/filter:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/mtbroker/filter@sha256:c3fcf096439ef7cd438b97f44e0318ca6d94b73c47953de768c92de584dbcd3c].
 Created [eu.gcr.io/knative-releases/knative.dev/eventing/cmd/mtbroker/filter:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/mtbroker/filter@sha256:c3fcf096439ef7cd438b97f44e0318ca6d94b73c47953de768c92de584dbcd3c].
 Created [asia.gcr.io/knative-releases/knative.dev/eventing/cmd/mtbroker/filter:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/mtbroker/filter@sha256:c3fcf096439ef7cd438b97f44e0318ca6d94b73c47953de768c92de584dbcd3c].
 Created [gcr.io/knative-releases/knative.dev/eventing/cmd/mtbroker/ingress:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/mtbroker/ingress@sha256:1af3d594ca277ae16c94279506c1786851b1e4c504539fa2840f777c61cb8876].
 Created [us.gcr.io/knative-releases/knative.dev/eventing/cmd/mtbroker/ingress:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/mtbroker/ingress@sha256:1af3d594ca277ae16c94279506c1786851b1e4c504539fa2840f777c61cb8876].
 Created [eu.gcr.io/knative-releases/knative.dev/eventing/cmd/mtbroker/ingress:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/mtbroker/ingress@sha256:1af3d594ca277ae16c94279506c1786851b1e4c504539fa2840f777c61cb8876].
 Created [asia.gcr.io/knative-releases/knative.dev/eventing/cmd/mtbroker/ingress:v0.17.0].
 Updated [gcr.io/knative-releases/knative.dev/eventing/cmd/mtbroker/ingress@sha256:1af3d594ca277ae16c94279506c1786851b1e4c504539fa2840f777c61cb8876].

It appears to have attempted to upload eventing.yaml:

Publishing [eventing-core.yaml eventing-crds.yaml eventing-sugar-controller.yaml mt-channel-broker.yaml in-memory-channel.yaml eventing-pre-install-jobs.yaml eventing-post-install-jobs.yaml eventing-post-install-jobs.yaml eventing.yaml] to gs://knative-releases/eventing/latest/
Copying file://eventing-crds.yaml [Content-Type=application/octet-stream]...
Copying file://eventing-core.yaml [Content-Type=application/octet-stream]...
Copying file://eventing-sugar-controller.yaml [Content-Type=application/octet-stream]...
Copying file://mt-channel-broker.yaml [Content-Type=application/octet-stream]...
Copying file://in-memory-channel.yaml [Content-Type=application/octet-stream]...
Copying file://eventing-pre-install-jobs.yaml [Content-Type=application/octet-stream]...
Copying file://eventing-post-install-jobs.yaml [Content-Type=application/octet-stream]...
Copying file://eventing-post-install-jobs.yaml [Content-Type=application/octet-stream]...
Copying file://eventing.yaml [Content-Type=application/octet-stream]...
/ [0/9 files][    0.0 B/471.2 KiB]   0% Done                                    ^M/ [0/9 files][    0.0 B/471.2 KiB]   0% Done                                    ^M/ [0/9 files][    0.0 B/471.2 KiB]   0% Done                                    ^M/ [0/9 files][    0.0 B/471.2 KiB]   0% Done                                    ^M/ [0/9 files][    0.0 B/471.2 KiB]   0% Done                                    ^M/ [1/9 files][280.2 KiB/471.2 KiB]  59% Done                                    ^M/ [2/9 files][280.2 KiB/471.2 KiB]  59% Done                                    ^M/ [3/9 files][280.2 KiB/471.2 KiB]  59% Done                                    ^M/ [3/9 files][280.2 KiB/471.2 KiB]  59% Done                                    ^M/ [4/9 files][280.2 KiB/471.2 KiB]  59% Done                                    ^M/ [4/9 files][280.2 KiB/471.2 KiB]  59% Done                                    ^M/ [5/9 files][280.2 KiB/471.2 KiB]  59% Done                                    ^M/ [5/9 files][280.2 KiB/471.2 KiB]  59% Done                                    ^M/ [5/9 files][280.2 KiB/471.2 KiB]  59% Done                                    ^M/ [6/9 files][470.3 KiB/471.2 KiB]  99% Done                                    ^M/ [7/9 files][470.3 KiB/471.2 KiB]  99% Done                                    ^M/ [8/9 files][470.3 KiB/471.2 KiB]  99% Done                                    ^MException in UIThread: 'file://eventing-post-install-jobs.yaml'
Publishing [eventing-core.yaml eventing-crds.yaml eventing-sugar-controller.yaml mt-channel-broker.yaml in-memory-channel.yaml eventing-pre-install-jobs.yaml eventing-post-install-jobs.yaml eventing-post-install-jobs.yaml eventing.yaml] to gs://knative-releases/eventing/previous/v0.17.0/
Copying file://eventing-core.yaml [Content-Type=application/octet-stream]...
Copying file://eventing-crds.yaml [Content-Type=application/octet-stream]...
Copying file://eventing-sugar-controller.yaml [Content-Type=application/octet-stream]...
Copying file://mt-channel-broker.yaml [Content-Type=application/octet-stream]...
Copying file://in-memory-channel.yaml [Content-Type=application/octet-stream]...
Copying file://eventing-pre-install-jobs.yaml [Content-Type=application/octet-stream]...
Copying file://eventing-post-install-jobs.yaml [Content-Type=application/octet-stream]...
Copying file://eventing-post-install-jobs.yaml [Content-Type=application/octet-stream]...
Copying file://eventing.yaml [Content-Type=application/octet-stream]...
/ [0/9 files][    0.0 B/471.2 KiB]   0% Done                                    ^M/ [0/9 files][    0.0 B/471.2 KiB]   0% Done                                    ^M/ [0/9 files][    0.0 B/471.2 KiB]   0% Done                                    ^M/ [0/9 files][148.0 KiB/471.2 KiB]  31% Done                                    ^M/ [0/9 files][247.1 KiB/471.2 KiB]  52% Done                                    ^M/ [1/9 files][280.2 KiB/471.2 KiB]  59% Done                                    ^M/ [2/9 files][280.2 KiB/471.2 KiB]  59% Done                                    ^M/ [3/9 files][280.2 KiB/471.2 KiB]  59% Done                                    ^M/ [4/9 files][280.2 KiB/471.2 KiB]  59% Done                                    ^M/ [4/9 files][280.2 KiB/471.2 KiB]  59% Done                                    ^M/ [4/9 files][280.2 KiB/471.2 KiB]  59% Done                                    ^M/ [5/9 files][280.2 KiB/471.2 KiB]  59% Done                                    ^M/ [5/9 files][280.2 KiB/471.2 KiB]  59% Done                                    ^M/ [5/9 files][280.2 KiB/471.2 KiB]  59% Done                                    ^M/ [6/9 files][470.3 KiB/471.2 KiB]  99% Done                                    ^M/ [7/9 files][470.3 KiB/471.2 KiB]  99% Done                                    ^M/ [8/9 files][470.3 KiB/471.2 KiB]  99% Done                                    ^MException in UIThread: 'file://eventing-post-install-jobs.yaml'
To https://github.com/knative/eventing
 * [new tag]           v0.17.0 -> v0.17.0
Attaching 9 assets...
The release was created, but attaching 2 assets failed. You can retry with:
hub release edit v0.17.0 -m '' -a eventing-post-install-jobs.yaml -a eventing.yaml

Error uploading release asset: Unprocessable Entity (HTTP 422)
Duplicate value for "name"
Error publishing the release, retrying in 15s...
Error creating release: Unprocessable Entity (HTTP 422)
Duplicate value for "tag_name"
Error publishing the release, retrying in 15s...
Error creating release: Unprocessable Entity (HTTP 422)
Duplicate value for "tag_name"
error: Cannot publish release to GitHub

@Harwayne
Copy link
Contributor

It looks like eventing-post-install-jobs.yaml has a problem uploading. That causes publishing to stop uploading, so it never reaches the files that are later in the command, namely eventing.yaml.

Publishing [eventing-core.yaml eventing-crds.yaml eventing-sugar-controller.yaml mt-channel-broker.yaml in-memory-channel.yaml eventing-pre-install-jobs.yaml eventing-post-install-jobs.yaml eventing-post-install-jobs.yaml eventing.yaml] to gs://knative-releases/eventing/previous/v0.17.0/

Oddly enough, we seem to generate the same YAML for both 0.16 and 0.17 post-release jobs.

Trying to figure out:

  1. Why we are still generating post-release jobs for 0.16 in the 0.17 release.
  2. Why the YAML does not upload correctly.
  3. Why does the system continue to tag a release when uploading its assets partially fail.

@Harwayne Harwayne mentioned this issue Aug 19, 2020
Closed
@Harwayne
Copy link
Contributor

I don't think eventing-post-install-jobs.yaml was empty because it should have passed through the line:

[[ -s ${artifact} ]] || abort "Artifact ${artifact} is empty"

And we don't see the error line.

@Harwayne
Copy link
Contributor

Questions from above:

  1. Why we are still generating post-release jobs for 0.16 in the 0.17 release.
    This was an oversight. It is being removed.
  2. Why the YAML does not upload correctly.
    Still investigating.
  3. Why does the system continue to tag a release when uploading its assets partially fail.
    Failure to upload to GCS does not prevent a bad GitHub Release test-infra#2374

@Harwayne
Copy link
Contributor

  1. Why the YAML does not upload correctly.

I think this is caused by having the same file being uploaded twice. The first upload succeeds. The second fails with Exception in UIThread: 'file://eventing-post-install-jobs.yaml'. We can see that it is in the list of files to upload twice based on the log line:

Publishing [eventing-core.yaml eventing-crds.yaml eventing-sugar-controller.yaml mt-channel-broker.yaml in-memory-channel.yaml eventing-pre-install-jobs.yaml eventing-post-install-jobs.yaml eventing-post-install-jobs.yaml eventing.yaml] to gs://knative-releases/eventing/previous/v0.17.0/

So removing the old post-install job should allow eventing.yaml to be added to the release correctly.

@Harwayne Harwayne mentioned this issue Aug 19, 2020
Merged
@n3wscott n3wscott mentioned this issue Aug 19, 2020
Merged
Harwayne added a commit to Harwayne/knative-eventing that referenced this issue Aug 20, 2020
@Harwayne
Force the latest version to be v0.16.1.
c8aed8a 
v0.17.0 is a bad release, see knative#3873. It is blocking any new PRs and is blocking the creation of a new release because the bad release is being used in the upgrade test, causing it to fail.
@Harwayne Harwayne mentioned this issue Aug 20, 2020
Merged
knative-prow-robot pushed a commit that referenced this issue Aug 20, 2020
@Harwayne
Force the latest version to be v0.16.1. (#3887)
b174462 
v0.17.0 is a bad release, see #3873. It is blocking any new PRs and is blocking the creation of a new release because the bad release is being used in the upgrade test, causing it to fail.
@pierDipi
Copy link
Member

eventing.yaml released https://github.com/knative/eventing/releases/tag/v0.17.1
/close

@knative-prow-robot
Copy link
Contributor

@pierDipi: Closing this issue.

In response to this:

eventing.yaml released https://github.com/knative/eventing/releases/tag/v0.17.1
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Oct 26, 2020
Merged
Merged
@matzew matzew mentioned this issue Nov 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Harwayne Harwayne

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the old release-0.16 pre- and post- install jobs. Harwayne/knative-eventing
5 participants
@matzew @Harwayne @lionelvillard @pierDipi @knative-prow-robot