Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force the latest version to be v0.16.1. #3887

Merged

Conversation

Harwayne
Copy link
Contributor

Proposed Changes

  • Use v0.16.1 as the 'latest release'.
    • v0.17.0 is a bad release, see Eventing.yaml missing for 0.17 #3873. It is blocking any new PRs and is blocking the creation of a new release because the bad release is being used in the upgrade test, causing it to fail.

Once release v0.17.1 is created and is shown to work, revert this PR.

Release Note

NONE

v0.17.0 is a bad release, see knative#3873. It is blocking any new PRs and is blocking the creation of a new release because the bad release is being used in the upgrade test, causing it to fail.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 20, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 20, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 20, 2020
@nachocano
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2020
@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-conformance-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-conformance-tests:

test/conformance.TestBrokerV1Beta1DataPlaneConsumer

@Harwayne
Copy link
Contributor Author

/test pull-knative-eventing-conformance-tests

@knative-prow-robot knative-prow-robot merged commit b174462 into knative:release-0.17 Aug 20, 2020
@Harwayne Harwayne deleted the force-latest-version-16-1 branch August 20, 2020 06:13
@Harwayne
Copy link
Contributor Author

Once release v0.17.1 is created and is shown to work, revert this PR.

Actually, I think we should leave this as-is, because merging another PR will cause a new point release to be created. If there are no other changes in the code, then it would be identical to 0.17.1.

Harwayne added a commit to Harwayne/knative-eventing that referenced this pull request Aug 27, 2020
knative-prow-robot pushed a commit that referenced this pull request Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants