Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs on how to run conf tests against preexisting broker #3872

Merged
merged 3 commits into from
Aug 20, 2020
Merged

Add docs on how to run conf tests against preexisting broker #3872

merged 3 commits into from
Aug 20, 2020

Conversation

lberk
Copy link
Member

@lberk lberk commented Aug 18, 2020

Also, fix being able to run conf tests against existing broker 🤦
Fixes #3667

@lberk
Add docs on how to run conf tests against preexisting broker
a044b2c 
Also, fix being able to run conf tests against existing broker 🤦
Fixes knative#3667
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 18, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Aug 18, 2020
mattmoor
mattmoor reviewed Aug 18, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)

@lberk
Copy link
Member Author

lberk commented Aug 19, 2020

/test pull-knative-eventing-upgrade-tests

pierDipi
pierDipi reviewed Aug 19, 2020
View reviewed changes
test/conformance/helpers/broker_data_plane_test_helper.go Outdated Show resolved Hide resolved
test/lib/resources/eventing.go Outdated Show resolved Hide resolved
test/conformance/README.md

```shell
go test -v -tags e2e knative.dev/eventing/test/conformance -brokername=foo -brokernamespace=bar -run TestBrokerV1Beta1DataPlaneIngress

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: empty line

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 19, 2020
@pierDipi
Copy link
Member

@lberk, test failures are related to the issue #3873.

pierDipi
pierDipi approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-upgrade-tests 2020-08-19 13:50:40.945 +0000 UTC
2020-08-19 13:56:40.863 +0000 UTC
2020-08-19 14:03:10.683 +0000 UTC
2020-08-19 14:11:10.696 +0000 UTC		 3/3

Job pull-knative-eventing-upgrade-tests expended all 3 retries without success.

@vaikas
Copy link
Contributor

vaikas commented Aug 19, 2020

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lberk, pierDipi, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2020
@pierDipi
Copy link
Member

eventing.yaml released https://github.com/knative/eventing/releases/tag/v0.17.1
/retest

@knative-prow-robot knative-prow-robot merged commit a16efe4 into knative:master Aug 20, 2020
@pierDipi pierDipi mentioned this pull request Sep 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@pierDipi pierDipi pierDipi approved these changes

@steuhs steuhs Awaiting requested review from steuhs

@yt3liu yt3liu Awaiting requested review from yt3liu

Assignees

@vaikas vaikas

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create documentation for how to run conformance tests against a pre-existing broker.
7 participants
@lberk @pierDipi @knative-test-reporter-robot @vaikas @knative-prow-robot @mattmoor @googlebot