Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the old release-0.16 pre- and post- install jobs. #3884

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

Harwayne
Copy link
Contributor

This should fix #3873, but we'll leave that issue open until a release with eventing.yaml has been created.

Proposed Changes

  • Remove the old release-0.16 pre- and post- install jobs.

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 19, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 19, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Aug 19, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2020
@n3wscott
Copy link
Contributor

you need to push this to the release-0.17 branch, not master

@Harwayne Harwayne changed the base branch from master to release-0.17 August 19, 2020 20:11
@Harwayne
Copy link
Contributor Author

you need to push this to the release-0.17 branch, not master

D'oh. Done.

@n3wscott
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020
@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-upgrade-tests 2020-08-19 19:33:40.67 +0000 UTC
2020-08-19 19:41:10.861 +0000 UTC
2020-08-19 19:47:10.923 +0000 UTC
2020-08-19 19:54:10.882 +0000 UTC
2020-08-19 20:19:40.658 +0000 UTC
3/3

Job pull-knative-eventing-upgrade-tests expended all 3 retries without success.

@Harwayne
Copy link
Contributor Author

Discussed in slack. This change is only for release.sh, so it does not affect the code or config. The tests for this PR, and all other PRs in this repo, will fail because it tries to find the latest release's eventing.yaml, which the 0.17.0 release lacks. @lionelvillard agreed that we should just force this in.

@Harwayne Harwayne merged commit fd0a0fe into knative:release-0.17 Aug 19, 2020
@knative-prow-robot
Copy link
Contributor

@Harwayne: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-upgrade-tests 1aa3077 link /test pull-knative-eventing-upgrade-tests
pull-knative-eventing-conformance-tests 1aa3077 link /test pull-knative-eventing-conformance-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eventing.yaml missing for 0.17
5 participants