Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unpin knative deps for post-0.17 release #3882

Merged
merged 2 commits into from
Aug 20, 2020
Merged

unpin knative deps for post-0.17 release #3882

merged 2 commits into from
Aug 20, 2020

Conversation

n3wscott
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 19, 2020
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Aug 19, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2020
Harwayne
Harwayne reviewed Aug 19, 2020
View reviewed changes
Copy link
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Holding in case you want to switch.

hack/update-deps.sh Outdated
@@ -31,8 +31,8 @@ cd "${ROOT_DIR}"
# The list of dependencies that we track at HEAD and periodically
# float forward in this repository.
FLOATING_DEPS=(
"knative.dev/test-infra@release-0.17"
"knative.dev/pkg@release-0.17"
"knative.dev/test-infra@master"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, my preference is:

Suggested change
"knative.dev/test-infra@master"
"knative.dev/test-infra@${VERSION}"

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2020
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020
Harwayne
Harwayne reviewed Aug 19, 2020
View reviewed changes
Copy link
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020
@Harwayne
Copy link
Contributor

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2020
@n3wscott
Copy link
Contributor Author

no clear error on the upgrade test...

error: unable to retrieve the complete list of server APIs: metrics.k8s.io/v1beta1: the server is currently unable to handle the request

@n3wscott
Copy link
Contributor Author

/retest

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-upgrade-tests 2020-08-19 18:58:10.655 +0000 UTC
2020-08-19 19:04:40.834 +0000 UTC
2020-08-19 19:11:40.659 +0000 UTC
2020-08-19 19:18:10.855 +0000 UTC
2020-08-19 19:45:40.825 +0000 UTC		 3/3

Job pull-knative-eventing-upgrade-tests expended all 3 retries without success.

@n3wscott
Copy link
Contributor Author

ah, this is the real error:

--2020-08-19 19:45:00--  https://github.com/knative/eventing/releases/download/v0.17.0/eventing.yaml
Resolving github.com (github.com)... 140.82.114.3
Connecting to github.com (github.com)|140.82.114.3|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2020-08-19 19:45:00 ERROR 404: Not Found.

@Harwayne is looking into fixing the release.

@n3wscott
Copy link
Contributor Author

blocked on #3873

@pierDipi
Copy link
Member

eventing.yaml released https://github.com/knative/eventing/releases/tag/v0.17.1
/retest

@knative-prow-robot knative-prow-robot merged commit f68ed3b into knative:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harwayne Harwayne Harwayne left review comments

@mattmoor mattmoor mattmoor left review comments

@yt3liu yt3liu Awaiting requested review from yt3liu

Assignees

@Harwayne Harwayne

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@n3wscott @knative-prow-robot @Harwayne @knative-test-reporter-robot @pierDipi @mattmoor @googlebot