Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twopanedemo #2

Closed
wants to merge 87 commits into from
Closed

Twopanedemo #2

wants to merge 87 commits into from

Conversation

kmelmon
Copy link
Owner

@kmelmon kmelmon commented Nov 2, 2019

No description provided.

kmelmon and others added 30 commits October 16, 2019 17:06
* merge

* exclude Generated Files

* Change files
* Support onSubmitEditing event

* Address PR comments

* Change files
* Support autoCapitalize Characters

* Change files

* Add check to make sure we can support TextBox.CharacterCasing property
* merge in basic slider

* Fix two issues:
1) you cannot animated 2 subchannels of the same property with different animations. to fix this we animated yet another property set for translation and scale owned by the props nodes and use one animation to animate all of the subchannels for the uiElement.
2) Reference parameter names which started with a multi digit number are unsupported so i added an n to the start of each name, which was previously just the node's tag.

* Change files

* yarn format

* Fix an issue with spring animations that did not start from 0, causing them to double count the start value.

* respond to feedback.

* yarn format
* Update to react-native@0.60.0-microsoft.8

* Change files

* Change files
* Don't hardcode the path to v141 platform toolset
* Support 2017/2019 installs and side-by-side installs
* Support non-C drive installs
* install UWP v141 in the lab
* per-arch v141 package support
* merge

* beginnings of adding EnableDeveloperMenu API

* finish initial implementation

* md updates

* use the new flag everywhere

* Change files

* change file + yarn

* fix e2e test
* Fix run-windows app installation hang

* Change files

* Minor change

* perttier

* PR comments
This commit:

- Introduces ChakraObjectRef, an RAII wrapper for JsRefs.
- Replaces ChakraPropertyIdValue, ChakraStringValue, ChakraObjectValue, and ChakraWeakRefValue with a new class ChakraPointerValue, which is implemented on top of ChakraObjectRef.
- Fix property ID comparison for ChakraRuntime.
- Temporarily disables weak ref semantics for ChakraCore based Runtime. This functionality will be re-enabled in a future commit.
* Create win10compat.md

* Update GettingStarted.md

* Update README.md
* merge

* Change files

* always publish binlog, comment out targets

* comment out targets

* change to succeededOrFailed.  Of course!

* move condition outside inputs.  Of course!

* add more binlogs

* tweak path

* joy!  reverse engineering pathToPublish is fun

* sheesh. still trying to find the binlog

* use Build.SourcesDirectory to locate binlog

* typo

* giving up on /bl.  Trying another option

* publish log

* add timeout

* log more build jobs

* change publish path

* try #2 at getting the right publish path

* remove clean
* Update to react-native@0.60.0-microsoft.9

* Change files

* Change files
* Create Calculated Animation which allows for animations that don't follow Bezier curves

* Change files

* clang format

* edit comment
…perties instead (microsoft#3501)

* Removed MainReactNativeHost from samples and use ReactApplication properties instead.

* Change files
…NuGet randomly fails (microsoft#3492)

* Timeout for integration test

* reverse the order

* Update windows-vs-pr.yml for Azure Pipelines

* catch exception

* add blame

* Change files

* timer to 300s

* Ping metro bundle and re-run test when failed.

* Exclude the problem of bundle server not ready

Change wait time to 2min

* Disable IntegrationTestHarnessTest
* Update to react-native@0.60.0-microsoft.11

* Change files

* Change files
* change clang format column count to 120

* Change files

* add clang format
…tedModule (microsoft#3509)

* register the empty functions

* register empty stubs

* Change files

* add postfix Name for consistency
rnbot and others added 25 commits October 29, 2019 01:31
* Support Keyboard events
* Fix crash in RS5 due to missing facade property

* Change files
* Replace Build.ArtifactStagingDirectory with Build.StagingDirectory.
They are equivalent as stated in Azure DevOps documentation.

* Use variable templates.

* Use $(SDKVersion).

* Update

* Update

* Update

* Default Universal to x64.

* Rename back to Build.ArtifactStagingDirectory.

* Change files

* Update

* Update

* Set WindowsSdkPath.

* Update

* Rename SDKVersion to Win10Version.

* Drop WindowsSdkPath.

* Use Build.StagingDirectory.

* Update windows-vs-pr.yml
* Remove boost.datetime from Desktop DLL.

* Define BOOST_ALL_NO_LIB=1

* Removed boost_date_time from remaining projects.

* Change files
* Update RNTesterIntegrationTests.cpp

* Change files
* fix build error

* Change files
* Set a default 3D perspective

* format

* Change files

* add comment
* Update to react-native@0.60.0-microsoft.14

* Change files

* Change files
…osoft#3568)

In 0752e64, we modified ChakraRuntime::getPropertyNames() so that it returns all non-enumerable properties along the property chain (this matches the behavior of HermesRuntime.) However, in doing so, we switched its implementation from native to JS. This introduced a massive performance regression, and we had to revert back to the old implementation (see 911ea3c.)

This PR attempts to correct the native implementation of ChakraRuntime::getPropertyNames(). The new implementation is still slower due to the checking of enumerability.
* Call native animation callbacks only once

* Change files
This commit contains some small renaming and best practice changes.
@kmelmon kmelmon closed this Nov 2, 2019
kmelmon added a commit that referenced this pull request Aug 13, 2020
kmelmon added a commit that referenced this pull request Aug 14, 2020
kmelmon added a commit that referenced this pull request Aug 17, 2020
kmelmon added a commit that referenced this pull request Aug 19, 2020
* re-enable

* comment out PlatformColor test, this was the failing test in the past as well

* trying again, this time commenting out PanResponder Sample, which comes just before the failing test

* trying to wait for home page to load before continuing

* another take on waiting for item in FlatList to be loaded first

* trying new approach, enter test name in edit box to filter first

* made some progress, now timing out on edit control, add polling for that control

* finally!  success.  Try #2

* try #3, fingers crossed!

* try #4

* split test into groups

* bumping up timeout

* try #2 with longer timeout

* go back to one testspec

* try #4 with longer timeout

* try #5 with longer timeout.  really folks I think I got it this time :)

* convert all the tests to use same mechanism

* Change files

* remove smoke test

* stability pass after removing smoke test, try #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.