Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use variable templates #3548

Merged
merged 18 commits into from
Oct 30, 2019
Merged

Conversation

JunielKatarn
Copy link
Contributor

@JunielKatarn JunielKatarn commented Oct 28, 2019

Uses templates for common variable groups.
Simplifies switching from VS2017 to VS2019.

Microsoft Reviewers: Open in CodeFlow

@JunielKatarn JunielKatarn requested a review from a team as a code owner October 28, 2019 23:11
@JunielKatarn JunielKatarn added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Oct 28, 2019
@ghost
Copy link

ghost commented Oct 28, 2019

Hello @JunielKatarn!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 26 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@asklar
Copy link
Member

asklar commented Oct 29, 2019

:shipit:

@JunielKatarn
Copy link
Contributor Author

Hi, @asklar. Can you please approve?

@acoates-ms acoates-ms merged commit 580bd6d into microsoft:master Oct 30, 2019
@asklar asklar self-requested a review October 30, 2019 03:29
@JunielKatarn JunielKatarn deleted the DevOps/varsfromtemplate branch October 30, 2019 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants