Keyboard #3541
Merged
Keyboard #3541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 28, 2019 10:35
ddalp
requested review from
marlenecota,
licanhua,
jonthysell,
asklar,
chrisglein and
kmelmon
ddalp
commented
Oct 28, 2019
| #include <winrt/Windows.UI.Input.h> | ||
| #include <winrt/Windows.UI.Xaml.Controls.h> | ||
| #include <winrt/Windows.UI.Xaml.Input.h> | ||
| #include <winrt/Windows.UI.Xaml.Media.h> |
added 2 commits
October 28, 2019 11:52
asklar
reviewed
Oct 28, 2019
| REACTWINDOWS_API_(bool) IsEmptyRect(winrt::Windows::Foundation::Rect rect); | ||
| REACTWINDOWS_API_(winrt::Windows::Foundation::Rect) CreateEmptyRect(); | ||
| REACTWINDOWS_API_(winrt::Windows::Foundation::Rect) | ||
| UnionRect(winrt::Windows::Foundation::Rect rect1, _In_ winrt::Windows::Foundation::Rect rect2); |
There was a problem hiding this comment.
when passing Rect pass instead const Rect& #Resolved
asklar
reviewed
Oct 28, 2019
vnext/ReactUWP/Utils/RectUtils.cpp
Outdated
| float GetBottom(_In_ winrt::Rect rect) { | ||
| return (IsEmptyRect(rect) ? NegativeInfinity : rect.Y + rect.Height); | ||
| } | ||
|
|
asklar
reviewed
Oct 28, 2019
vnext/ReactUWP/Utils/RectUtils.cpp
Outdated
| } | ||
|
|
||
| REACTWINDOWS_API_(bool) IsEmptyRect(winrt::Rect rect) { | ||
| return rect.Width < 0; |
There was a problem hiding this comment.
< [](start = 20, length = 1)
<= ?
There was a problem hiding this comment.
In fact consider reusing user32's IsRectEmpty instead
In reply to: 339777475 [](ancestors = 339777475)
asklar
reviewed
Oct 28, 2019
vnext/ReactUWP/Utils/RectUtils.cpp
Outdated
| result.X = std::numeric_limits<float>::infinity(); | ||
| result.Y = std::numeric_limits<float>::infinity(); | ||
| result.Width = -std::numeric_limits<float>::infinity(); | ||
| result.Height = -std::numeric_limits<float>::infinity(); |
There was a problem hiding this comment.
should set these to 0? #Resolved
asklar
reviewed
Oct 28, 2019
vnext/ReactUWP/Utils/RectUtils.cpp
Outdated
| // Update this rectangle to be the union of this and rect. | ||
| REACTWINDOWS_API_(winrt::Rect) UnionRect(winrt::Rect rect1, _In_ winrt::Rect rect2) { | ||
| winrt::Rect result = rect1; | ||
| if (IsEmptyRect(rect1)) { |
There was a problem hiding this comment.
can you just call the user32 UnionRect?
UnionRect(ToRECT(rect1), ToRECT(rect2)) #Resolved
asklar
reviewed
Oct 28, 2019
| private: | ||
| void SendEvent(std::string &&eventName, folly::dynamic &¶meters); | ||
| std::weak_ptr<IReactInstance> m_wkReactInstance; | ||
| winrt::CoreInputView::OcclusionsChanged_revoker m_occlusionsChnaged_revoker; |
There was a problem hiding this comment.
m_occlusionsChnaged_revoker [](start = 50, length = 27)
fix typo: Ch n aged #Resolved
ghost
added
the
Needs: Author Feedback
ddalp
commented
Oct 28, 2019
| REACTWINDOWS_API_(bool) IsEmptyRect(winrt::Windows::Foundation::Rect rect); | ||
| REACTWINDOWS_API_(winrt::Windows::Foundation::Rect) CreateEmptyRect(); | ||
| REACTWINDOWS_API_(winrt::Windows::Foundation::Rect) | ||
| UnionRect(winrt::Windows::Foundation::Rect rect1, _In_ winrt::Windows::Foundation::Rect rect2); |
There was a problem hiding this comment.
There is already RectHelper class I can use, will remove . #Resolved
ghost
removed
the
Needs: Author Feedback
added 2 commits
October 28, 2019 15:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2852
Microsoft Reviewers: Open in CodeFlow