Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable IntegrationTestHarness #3542

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Enable IntegrationTestHarness #3542

merged 2 commits into from
Oct 30, 2019

Conversation

licanhua
Copy link
Contributor

@licanhua licanhua commented Oct 28, 2019 •
edited by ghost
Loading

Test is disable when investigating #3444, re-enable it.

Microsoft Reviewers: Open in CodeFlow

@licanhua licanhua requested a review from a team as a code owner October 28, 2019 18:26
@ghost ghost added the vnext label Oct 28, 2019
@JunielKatarn
Copy link
Contributor

What was the issue with this test to begin with?
In my local dev test runs, it had never failed before.

@JunielKatarn
Copy link
Contributor

For future test enabling/disabling, please modify the build variable Desktop.IntegrationTests.Filter instead (see windows-vs-pr.yml):

(FullyQualifiedName!~WebSocketJSExecutorIntegrationTest)&(FullyQualifiedName!~<whichever test you want to disable>)

This is especially important if tests are only failing in the PR loops, but not in local dev machines (which has been the case for most of the Desktop integration tests).

@licanhua licanhua merged commit 1a82a2c into microsoft:master Oct 30, 2019
@licanhua licanhua deleted the EnableIntegrationTestHarness branch October 30, 2019 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunielKatarn JunielKatarn JunielKatarn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@licanhua @JunielKatarn