Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix run-windows app installation hang #3447

Merged
merged 6 commits into from
Oct 18, 2019
Merged

Fix run-windows app installation hang #3447

merged 6 commits into from
Oct 18, 2019

Conversation

ddalp
Copy link
Contributor

@ddalp ddalp commented Oct 17, 2019 •
edited
Loading

#3190

  • "run-windows" hang is caused by waiting for user pressing Enter at end of app package installation, if a developer certificate needs to be installed. We don't see the prompt because spinner is in control. To suppress the prompt, we should always use -force parameter.
  • Using -force parameter can fail if the developer mode is not enabled, this is not a problem on build machine, but can happen on fresh developer OS and it will fail when user issue "react-native run-windows" command, so adding a step to always enable developer mode.
Microsoft Reviewers: Open in CodeFlow

@ddalp ddalp marked this pull request as ready for review October 17, 2019 16:22
@ddalp ddalp requested a review from a team as a code owner October 17, 2019 16:22
@acoates-ms
Copy link
Contributor

acoates-ms commented Oct 17, 2019 •
edited by ddalp
Loading

An alternative would be to always allow output from the install command. -- Which might make sense. Its not a very noisy command output wise, compared to say build. And would allow the user to still have proper control over the prompt.

Not sure what peoples thoughts on that are though. #Resolved

@ddalp
Copy link
Contributor Author

ddalp commented Oct 17, 2019

I think it is still better to have spinner running by default for all steps, to be consistent.
If there are problems, we can always ask user to run command with --logging which will turn on the prompt.

In reply to: 543260149 [](ancestors = 543260149)

@microsoft microsoft deleted a comment from acoates-ms Oct 17, 2019
asklar
asklar reviewed Oct 18, 2019
View reviewed changes
vnext/local-cli/runWindows/utils/deploy.js Outdated
const installingText = 'Installing new version of the app';
const installApp = `-ExecutionPolicy RemoteSigned Import-Module "${windowsStoreAppUtils}"; Install-App "${script}"`;
const installAppCmd = options.force ? installApp + ' -Force' : installApp;
const installApp = `-ExecutionPolicy RemoteSigned Import-Module "${windowsStoreAppUtils}"; Install-App "${script}" -Force`;
Copy link
Member

@asklar asklar Oct 18, 2019 •
edited by ddalp
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

installApp [](start = 8, length = 10)

add -NoProfile here too :) #Resolved

asklar
asklar approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@asklar asklar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@acoates-ms acoates-ms merged commit d8826d6 into microsoft:master Oct 18, 2019
@ddalp ddalp deleted the AppPackageFix branch October 18, 2019 22:23
@licanhua licanhua mentioned this pull request Nov 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asklar asklar asklar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddalp @acoates-ms @asklar