Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configure eslint rules to show warnings instead of errors #995

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

SGrueber
Copy link
Collaborator

@SGrueber SGrueber commented Feb 2, 2022

PR Type

[x] Other: ESLint configuration

What Is the Current Behavior?

Many eslint rules are configured to cause an error, which is sometimes disruptive.

What Is the New Behavior?

The eslint rules have been checked to cause only an error if it is necessary. All other rules only cause a warning.

Does this PR Introduce a Breaking Change?

[x] No

Other Information

AB#73844

@SGrueber SGrueber requested a review from MaxKless February 2, 2022 12:40
@SGrueber SGrueber self-assigned this Feb 2, 2022
@SGrueber SGrueber added the enhancement Enhancement to an existing feature label Feb 2, 2022
@SGrueber SGrueber added this to the 2.0 milestone Feb 2, 2022
@shauke shauke changed the title refactor: transform some eslint errors to warnings chore: configure eslint rules to show warnings instead of errors if it seems more appropriate Feb 3, 2022
@shauke shauke changed the title chore: configure eslint rules to show warnings instead of errors if it seems more appropriate chore: configure eslint rules to show warnings instead of errors Feb 4, 2022
@shauke shauke merged commit f7750c6 into develop Feb 4, 2022
@shauke shauke deleted the refactor/eslint_errors_to_warnings branch February 4, 2022 10:44
SGrueber pushed a commit that referenced this pull request May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants