refactor: remove deprecated form components #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
force-pushed
the
refactor/remove_deprecated_form_artifacts
branch
from
18a823b to
7b2a212
Compare
SGrueber
force-pushed
the
refactor/remove_deprecated_form_artifacts
branch
from
7b2a212 to
d01109f
Compare
BREAKING CHANGES: The `SelectOption` interface has been moved to the select-option.model.ts file of the core/model folder, the related import statements have been adapted.
SGrueber
added a commit
that referenced
this pull request
Dec 10, 2021
BREAKING CHANGES: Our deprecated form components have been removed, use Formly to generate and maintain your forms. (see [Migrations / 1.4 to 2.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#14-to-20) for more details.
SGrueber
added a commit
that referenced
this pull request
Dec 10, 2021
SGrueber
force-pushed
the
refactor/remove_deprecated_form_artifacts
branch
from
d01109f to
ec372cd
Compare
BREAKING CHANGES: Our deprecated form components have been removed, use Formly to generate and maintain your forms. (see [Migrations / 1.4 to 2.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#14-to-20) for more details.
SGrueber
added a commit
that referenced
this pull request
Dec 10, 2021
SGrueber
force-pushed
the
refactor/remove_deprecated_form_artifacts
branch
from
ec372cd to
1f0697e
Compare
SGrueber
force-pushed
the
refactor/remove_deprecated_form_artifacts
branch
from
1f0697e to
0d500c0
Compare
shauke
approved these changes
Dec 10, 2021
MaxKless
approved these changes
Dec 10, 2021
SGrueber
added a commit
that referenced
this pull request
Dec 10, 2021
BREAKING CHANGES: The `SelectOption` interface has been moved to the select-option.model.ts file of the core/model folder, the related import statements have been adapted.
SGrueber
added a commit
that referenced
this pull request
Dec 10, 2021
BREAKING CHANGES: Our deprecated form components have been removed, use Formly to generate and maintain your forms. (see [Migrations / 1.4 to 2.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#14-to-20) for more details.
SGrueber
added a commit
that referenced
this pull request
May 19, 2022
BREAKING CHANGES: The `SelectOption` interface has been moved to the select-option.model.ts file of the core/model folder, the related import statements have been adapted.
SGrueber
added a commit
that referenced
this pull request
May 19, 2022
BREAKING CHANGES: Our deprecated form components have been removed, use Formly to generate and maintain your forms. (see [Migrations / 1.4 to 2.0](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#14-to-20) for more details.
SGrueber
added a commit
that referenced
this pull request
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Refactoring (no functional changes, no API changes)
What Is the Current Behavior?
There are deprecated form components.
Issue Number: Closes #817
What Is the New Behavior?
There are no deprecated form components any more. The interface 'SelectOption' has been moved to the model folder.
Does this PR Introduce a Breaking Change?
[x] Yes
Use the formly module to build your forms. Find further documentation here:
https://formly.dev/guide/getting-started
https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/formly.md
Other Information
AB#71981