-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lazily resolve translate service in translate compiler #978
fix: lazily resolve translate service in translate compiler #978
Conversation
not solved completely yet 😢 |
01d8680
to
35ee368
Compare
@MaxKless NOW it is ready 😄 |
Sorry it took so long for me to review this. It looks good, but is there any more to the setup? |
@MaxKless Still happens for me. Try the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.translate().instant()
might look slightly weird, but imo it's a good, minimally invasive and unobtrusive change. Just a single comment.
Co-authored-by: max.kless@googlemail.com <max.kless@googlemail.com>
PR Type
[x] Bugfix
What Is the Current Behavior?
translate
functionality ofPWATranslateCompiler
breaks on SSR after the first SSR prerender.Steps to reproduce:
translate
functionality:npm run start
-> it will work properly the first time, but for every subsequent prerender the following errors are displayed in the console:
What Is the New Behavior?
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#72606