Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: local ICM cache for (performance) testing purposes #867

Merged
merged 2 commits into from
Feb 4, 2022
Merged

feat: local ICM cache for (performance) testing purposes #867

merged 2 commits into from
Feb 4, 2022

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Sep 9, 2021 •
edited
Loading

PR Type

[x] Feature

Description

local ICM cache for (performance) testing purposes.

Does this PR Introduce a Breaking Change?

[x] No

Other Information

AB#69659

@shauke shauke force-pushed the refactor/multi-pwa-container-build-local-icm-cache branch from 9e20416 to b56cb25 Compare September 16, 2021 15:12
@shauke shauke changed the title feat: local icm cache feat: ICM REST response cache for the PWA container Sep 16, 2021
@shauke shauke added the research Exploration for fancy new stuff label Sep 16, 2021
@dhhyi dhhyi force-pushed the refactor/multi-pwa-container-build-local-icm-cache branch 2 times, most recently from 5b6ad85 to 97cfa75 Compare September 19, 2021 14:43
@dhhyi dhhyi added the performance Performance improvements label Sep 20, 2021
@dhhyi dhhyi mentioned this pull request Sep 28, 2021
Merged
@dhhyi
Copy link
Collaborator Author

dhhyi commented Oct 4, 2021 •
edited
Loading

This PR should be abandoned in favor of #888.
Still, It would be nice to just have the icm-cache.js as a tool in the scripts or templates folder.
Opinions? @shauke @jometzner

@dhhyi dhhyi force-pushed the refactor/multi-pwa-container-build-local-icm-cache branch from 97cfa75 to 6756fdd Compare November 23, 2021 10:56
@dhhyi dhhyi changed the title feat: ICM REST response cache for the PWA container feat: local ICM cache for (performance) testing purposes Nov 23, 2021
@dhhyi dhhyi marked this pull request as ready for review November 23, 2021 10:57
@dhhyi dhhyi removed the performance Performance improvements label Nov 23, 2021
@shauke shauke added this to the 2.0 milestone Feb 3, 2022
@shauke shauke force-pushed the refactor/multi-pwa-container-build-local-icm-cache branch from 6756fdd to b73f8f9 Compare February 4, 2022 10:30
@shauke
Copy link
Collaborator

shauke commented Feb 4, 2022

Moved the file to \src\ssr\server-scripts and added helpful integration code snippets. This way it seems more useful for potential users. Fine with you @dhhyi?

shauke
shauke previously approved these changes Feb 4, 2022
View reviewed changes
@shauke shauke force-pushed the refactor/multi-pwa-container-build-local-icm-cache branch from b73f8f9 to e1e1d0d Compare February 4, 2022 11:40
@shauke shauke force-pushed the refactor/multi-pwa-container-build-local-icm-cache branch from e1e1d0d to 59d2b75 Compare February 4, 2022 13:11
@shauke shauke merged commit 9aedbfc into develop Feb 4, 2022
@shauke shauke deleted the refactor/multi-pwa-container-build-local-icm-cache branch February 4, 2022 14:54
SGrueber pushed a commit that referenced this pull request May 19, 2022
@dhhyi @SGrueber
feat: local ICM cache for (performance) testing purposes (#867)
a0e9dc2
SGrueber pushed a commit that referenced this pull request May 19, 2022
Merged PR 938: Migration to pwa 2.0
1ecf6a2 
Related work items: #867, #892, #923, #949, #950, #951, #953, #954, #956, #957, #965, #967, #969, #975, #976, #978, #980, #986, #987, #990, #991, #993, #994, #995, #996, #1002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shauke shauke shauke left review comments

Assignees

@jometzner jometzner

@dhhyi dhhyi

@shauke shauke

Labels
research Exploration for fancy new stuff
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dhhyi @shauke @jometzner