refactor: feature toggle #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: pdate fork repo
cesarGamaSa
changed the title
dhhyi
previously approved these changes
Dec 9, 2021
dhhyi
previously approved these changes
Dec 9, 2021
MaxKless
suggested changes
Dec 15, 2021
There was a problem hiding this comment.
Hi @cesarGamaSa, thanks for this great PR. It looks very good and basically ready to merge, I just have two small questions :)
|
Hey @MaxKless. Is there anything else to develop regarding this refactor? |
MaxKless
approved these changes
Dec 23, 2021
SGrueber
pushed a commit
that referenced
this pull request
May 19, 2022
Co-authored-by: César Sá <cesar.sa@external.atlascopco.com> Co-authored-by: Danilo Hoffmann <hoffmann@evident.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Feature toggle directive and overall functionality has an old structure.
What Is the New Behavior?
Feature toggle uses subscription like other directives (e.g: not role toggle directive).
Does this PR Introduce a Breaking Change?
[ ] Yes
[X] No
Other Information