-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comprehensive Rust v2 #1073
Comprehensive Rust v2 #1073
Conversation
d6b10c4
to
c66e784
Compare
c66e784
to
ecb88d1
Compare
This PR now contains the "new" course in There's still a lot of editing to do, and I'll start in on that from day 1 forward. |
0592424
to
3f0feba
Compare
5a54d73
to
f4c9b1a
Compare
I've got Day 1 morning and a bit of the afternoon ("Tuples and Arrays") edited together now. So far, rebasing hasn't been bad, as the upstream changes have been relatively straighforward and the sequence of commits in this PR helps guide Git to carry those changes through to the final product. However, I'm starting to lose the faith that this is going to work out:
I can keep working on this, and get to the end, but I'm worried that either it will be merged with "@djmitche did a lot of work so let's just merge it" resulting in a poor quality course until we can collectively improve it; or that review will take a long time and we'll end up basically forking the course. I can see a few fixes for this:
Thoughts? |
9173e6a
to
810ac59
Compare
Now rebased onto main, and with all of day-1 complete. That was probably ~8 hours work (mostly on planes to/from RustConf), so it could be a while until I finish the other two days. That said, days 2 and 3 changed less, so perhaps a little faster. |
e4583e2
to
b5723cc
Compare
Hey @djmitche, I haven't given this as much time as I should — I hope we can look at it in a sync meeting soon. One thing to discuss is how this will impact the translations (so you should make sure @henrif75 is aware of this — he can help by preemptively having our Localization team do translations and have them reviewed by the many Rust experts). My thinking right now is that we should implement google/mdbook-i18n-helpers#16 before we start publishing a new version of the course. We don't have anyone working on this issue yet, so that will require some thought. |
b5723cc
to
70b5e9d
Compare
Regarding translations, I think that should be "not too bad" -- I've tried to not unnecessarily rewrite text that is appropriate to the new slide. So I would hope that many of the translated messages carry over without issue. Maybe as the work here finishes (with all three days complete) we can look at the number of mismatches, fuzzy matches, and exact matches and make a plan from there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed day 1; lots of comments inline.
Awesome, that is a relief to hear! I have a suggestion here: we should extract the messages from this branch ~weekly and I'm reluctant to add special code for this into |
da48bf1
to
bbe451a
Compare
This moves a bit of content around, and notably creates a new segment, pattern-matching.
UPDATED:
The new outline has the following timings:
I'm comfortable with the distribution of content like this, until we've actually taught the course and gotten some harder data for how long each segment takes, at which point we can consider moving things around a bit more to even out the days. In particular, I've left the last day an hour short in case things slip! |
- Use full stop at end of each item. - Use ‘:’ instead of ‘-’. - Use tight list spacing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations Dustin! Amazing work here!
I forgot to remove this in google#1073 before merging.
I forgot to remove this in #1073 before merging.
I've taken some work by @fw-immunant and others on the new organization of the course and condensed it into a form amenable to a text editor and some computational analysis. You can see the inputs in
course.py
but the interesting bits are the output:outline.md
andslides.md
.The idea is to break the course into more, smaller segments with exercises at the ends and breaks in between. So
outline.md
lists the segments, their duration, and sums those durations up per-day. It shows we're about an hour too long right now! There are more details of the segments inslides.md
, or you can see mostly the same stuff incourse.py
.This now contains all of the content from the v1 course, ensuring both that we've covered everything and that we'll have somewhere to redirect every page.
I'd appreciate feedback on:
Fixes #1082.
Fixes #1465.