Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split solution pages into one page per problem #1065

Closed
mgeisler opened this issue Aug 11, 2023 · 6 comments · Fixed by #1073
Closed

Split solution pages into one page per problem #1065

mgeisler opened this issue Aug 11, 2023 · 6 comments · Fixed by #1073
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mgeisler
Copy link
Collaborator

When reviewing #913, I realized that we should show the solutions with one page per problem. Today, we show all solutions for Day N on a single page and that's confusing (and less flexible if we move things around).

@mgeisler mgeisler added the good first issue Good for newcomers label Aug 11, 2023
@mgeisler mgeisler added the help wanted Extra attention is needed label Aug 24, 2023
@dyoo
Copy link
Contributor

dyoo commented Aug 28, 2023

I would like to work on this.

@djmitche
Copy link
Collaborator

Let's hold off for a bit here -- the "version 2" of the course in #1073 will likely rearrange a bunch of solutions.

In fact, it would be interesting to think about how best to arrange the solutions. Perhaps we should just include each as a sub-slide of the exercise slide?

@dyoo
Copy link
Contributor

dyoo commented Aug 28, 2023

Ah, okay. Acknowledged. Holding off then. Let me withdraw #1137 for now then.

@mgeisler
Copy link
Collaborator Author

In fact, it would be interesting to think about how best to arrange the solutions. Perhaps we should just include each as a sub-slide of the exercise slide?

Yeah, the current "system" is just what came to mind first so we can certainly iterate on it 😄

By sub-slide, do you mean as a note at the bottom of the page? I feel that makes it a bit too easy to go straight to the solution.

@djmitche
Copy link
Collaborator

No, I meant that the next slide would include the solution, but be nested below the exercise so that it doesn't get its own row in the table of contents.

  - [Exercise: ..](unsafe/exercise.md)
    - [Solution](unsafe/exercise/solution.md)

@mgeisler
Copy link
Collaborator Author

No, I meant that the next slide would include the solution

Great, that could certainly work!

@djmitche djmitche self-assigned this Sep 18, 2023
@djmitche djmitche linked a pull request Oct 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants