-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update course-structure.md #1555
Conversation
Fixing a typo.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hi @rickyclarkson, are you able to sign the CLA? Then we can merge it PR. |
This takes out the huge example with lots of macro magic. I don't think we need it for an introductory course. I also cleaned up the formatting a little and made sure to distinguish between types and values. --------- Co-authored-by: Dustin J. Mitchell <djmitche@google.com>
…1482) Hello, JA translation team! (google#652) As part of google#1460, I normalized ja.po using mdbook-i18n-normalize 0.3.0. Steps taken: `mdbook-i18n-normalize`. I'm open to any feedback or suggestions. Thank you in advance!
I don't like shortening words, so I prefer "Documentation" over "Docs". I find this less jargony and thus easier to read (and potentially also easier to translate).
Hi, this is a tiny MR to add glossary entry for "trait bound". Could you someone review it? I'm open to suggeston, too. Thank you! Context: google#1436 (comment)
Head branch was pushed to by a user without write access
Done. Actually I'm a Googler, so I've added my corp email address to the account per internal instructions, and edited the commits. I'm a relative github noob, so this might not show up properly yet. If there are any issues I'll create a new PR. |
I wonder why this PR contains the big changes in ja.po by #1482. Do we need to merge the latest main branch into rickyclarkson:patch-1? |
That's a good question! @rickyclarkson do you want to push a clean version? |
Closing, I'll create a new PR. |
Fixing a typo.