Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update course-structure.md #1555

Closed
wants to merge 9 commits into from
Closed

Conversation

rickyclarkson
Copy link
Contributor

Fixing a typo.

Copy link

google-cla bot commented Dec 4, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djmitche djmitche enabled auto-merge (squash) December 4, 2023 20:49
@mgeisler
Copy link
Collaborator

Hi @rickyclarkson, are you able to sign the CLA? Then we can merge it PR.

mgeisler and others added 6 commits December 11, 2023 01:05
This takes out the huge example with lots of macro magic. I don't think
we need it for an introductory course.

I also cleaned up the formatting a little and made sure to distinguish
between types and values.

---------

Co-authored-by: Dustin J. Mitchell <djmitche@google.com>
…1482)

Hello, JA translation team!
(google#652)

As part of google#1460, I normalized ja.po using mdbook-i18n-normalize 0.3.0.

Steps taken: `mdbook-i18n-normalize`.

I'm open to any feedback or suggestions. Thank you in advance!
I don't like shortening words, so I prefer "Documentation" over "Docs".
I find this less jargony and thus easier to read (and potentially also
easier to translate).
Hi, this is a tiny MR to add glossary entry for "trait bound". Could you
someone review it? I'm open to suggeston, too. Thank you!
Context:
google#1436 (comment)
auto-merge was automatically disabled December 11, 2023 09:05

Head branch was pushed to by a user without write access

@rickyclarkson
Copy link
Contributor Author

Done. Actually I'm a Googler, so I've added my corp email address to the account per internal instructions, and edited the commits. I'm a relative github noob, so this might not show up properly yet. If there are any issues I'll create a new PR.

@keiichiw
Copy link
Collaborator

I wonder why this PR contains the big changes in ja.po by #1482. Do we need to merge the latest main branch into rickyclarkson:patch-1?

@djmitche
Copy link
Collaborator

That's a good question! @rickyclarkson do you want to push a clean version?

@rickyclarkson
Copy link
Contributor Author

Closing, I'll create a new PR.

@rickyclarkson rickyclarkson deleted the patch-1 branch December 13, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants