Simplify enums a little #1566
Merged
Simplify enums a little #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes out the huge example with lots of macro magic. I don't think we need it for an introductory course. I also cleaned up the formatting a little and made sure to distinguish between types and values.
djmitche
approved these changes
Dec 7, 2023
Co-authored-by: Dustin J. Mitchell <djmitche@google.com>
rickyclarkson
pushed a commit
to rickyclarkson/comprehensive-rust
that referenced
this pull request
Dec 11, 2023
This takes out the huge example with lots of macro magic. I don't think we need it for an introductory course. I also cleaned up the formatting a little and made sure to distinguish between types and values. --------- Co-authored-by: Dustin J. Mitchell <djmitche@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes out the huge example with lots of macro magic. I don't think we need it for an introductory course.
I also cleaned up the formatting a little and made sure to distinguish between types and values.