feat: adding aria-invalid when an input has an error for accessibility #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lloydaf
requested review from
nlopin,
martimalek,
div-Leo and
jonotrujillo
as code owners
martimalek
approved these changes
Sep 27, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2023
### [1.34.1](v1.34.0...v1.34.1) (2023-09-29) ### Bug Fixes * **input:** add aria-invalid when an input has an error ([#379](#379)) ([ec26782](ec26782))
martimalek
added a commit
that referenced
this pull request
Sep 29, 2023
* chore: dependency update * 1.32.2 * fix: add border secondary (#355) Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local> * chore(release): 1.32.2 [skip ci] ### [1.32.2](v1.32.1...v1.32.2) (2023-08-17) ### Bug Fixes * add border secondary ([#355](#355)) ([75243ec](75243ec)) * feat: add breadcrumbs component (#353) * feat: add breadcrumbs component * feat: add a11y properites --------- Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local> * chore(release): 1.33.0 [skip ci] ## [1.33.0](v1.32.2...v1.33.0) (2023-08-18) ### Features * add breadcrumbs component ([#353](#353)) ([ed82e05](ed82e05)) * feat: add error Tag and SelectList variants (#372) * fix: add Open Sans font to storybook * feat: add variants of tag component in Tag and SelectList (#354) * feat: add variants of tag component, resolve comments --------- Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com> * chore(release): 1.34.0 [skip ci] ## [1.34.0](v1.33.0...v1.34.0) (2023-09-01) ### Features * add error Tag and SelectList variants ([#372](#372)) ([e0eecdd](e0eecdd)), closes [#354](#354) * refactor: replace deprecated weak prop for secondary in text usages (#375) * refactor: migrate Datepicker to popper positioning engine (#378) * refactor: migrate Datepicker to popper positioning engine * build: remove react-tether dependency * chore: remove unnecessary prop types and use useState directly * main: export Breadcrumbs component * 1.34.1 * fix(input): add aria-invalid when an input has an error (#379) * chore(release): 1.34.1 [skip ci] ### [1.34.1](v1.34.0...v1.34.1) (2023-09-29) ### Bug Fixes * **input:** add aria-invalid when an input has an error ([#379](#379)) ([ec26782](ec26782)) * chore: ignore codemods tests fixtures when running stylelint --------- Co-authored-by: Nikolai Lopin <code@lopin.me> Co-authored-by: Leonardo <leonardo.divittorio@live.it> Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: hackbnw <420178+hackbnw@users.noreply.github.com> Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com> Co-authored-by: Jan Hamara <hamara.jan18@gmail.com> Co-authored-by: Lloyd Francis <lloydaf@gmail.com>
martimalek
added a commit
that referenced
this pull request
Feb 2, 2024
* chore: dependency update * 1.32.2 * fix: add border secondary (#355) Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local> * chore(release): 1.32.2 [skip ci] ### [1.32.2](v1.32.1...v1.32.2) (2023-08-17) ### Bug Fixes * add border secondary ([#355](#355)) ([75243ec](75243ec)) * feat: add breadcrumbs component (#353) * feat: add breadcrumbs component * feat: add a11y properites --------- Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local> * chore(release): 1.33.0 [skip ci] ## [1.33.0](v1.32.2...v1.33.0) (2023-08-18) ### Features * add breadcrumbs component ([#353](#353)) ([ed82e05](ed82e05)) * feat: add error Tag and SelectList variants (#372) * fix: add Open Sans font to storybook * feat: add variants of tag component in Tag and SelectList (#354) * feat: add variants of tag component, resolve comments --------- Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com> * chore(release): 1.34.0 [skip ci] ## [1.34.0](v1.33.0...v1.34.0) (2023-09-01) ### Features * add error Tag and SelectList variants ([#372](#372)) ([e0eecdd](e0eecdd)), closes [#354](#354) * refactor: replace deprecated weak prop for secondary in text usages (#375) * refactor: migrate Datepicker to popper positioning engine (#378) * refactor: migrate Datepicker to popper positioning engine * build: remove react-tether dependency * chore: remove unnecessary prop types and use useState directly * main: export Breadcrumbs component * 1.34.1 * fix(input): add aria-invalid when an input has an error (#379) * chore(release): 1.34.1 [skip ci] ### [1.34.1](v1.34.0...v1.34.1) (2023-09-29) ### Bug Fixes * **input:** add aria-invalid when an input has an error ([#379](#379)) ([ec26782](ec26782)) * fix(deps): crossOrigin prop is not required for inputs (#386) * chore(deps): move @testing-library/react-hooks to devDependencies * fix(deps): override @types/react of react-windowed-select to ^17.0.67 * chore(deps): pin @types/react overrides --------- Co-authored-by: Artur Miglio <arturmiglio@gmail.com> * chore(release): 1.34.2 [skip ci] ### [1.34.2](v1.34.1...v1.34.2) (2023-10-05) ### Bug Fixes * **deps:** crossOrigin prop is not required for inputs ([#386](#386)) ([b9e7217](b9e7217)) * fix: enhanced breadcrumbs style (#390) * fix: enhanced breadcrumbs style * fix: linting error 0 unit --------- Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local> * chore(release): 1.34.3 [skip ci] ### [1.34.3](v1.34.2...v1.34.3) (2023-10-11) ### Bug Fixes * enhanced breadcrumbs style ([#390](#390)) ([e364381](e364381)) * fix(infobanner): allow to override attrs in InfoBannerCard (#393) * chore(release): 1.34.4 [skip ci] ### [1.34.4](v1.34.3...v1.34.4) (2023-11-03) ### Bug Fixes * **infobanner:** allow to override attrs in InfoBannerCard ([#393](#393)) ([8b1457e](8b1457e)) * chore: pull request template cleanup * docs: correct changelog * docs: minor typo fixes --------- Co-authored-by: Nikolai Lopin <code@lopin.me> Co-authored-by: Leonardo <leonardo.divittorio@live.it> Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: hackbnw <420178+hackbnw@users.noreply.github.com> Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com> Co-authored-by: Jan Hamara <hamara.jan18@gmail.com> Co-authored-by: Lloyd Francis <lloydaf@gmail.com> Co-authored-by: Artur Miglio <arturmiglio@gmail.com> Co-authored-by: Nikolai Lopin <nikolai.lopin@free-now.com>
github-actions bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
## [2.1.0](v2.0.1...v2.1.0) (2024-02-02) ### Features * add breadcrumbs component ([#353](#353)) ([ed82e05](ed82e05)) * add error Tag and SelectList variants ([#372](#372)) ([e0eecdd](e0eecdd)), closes [#354](#354) ### Bug Fixes * **infobanner:** allow to override attrs in InfoBannerCard ([#393](#393)) ([8b1457e](8b1457e)) * enhanced breadcrumbs style ([#390](#390)) ([e364381](e364381)) * **deps:** crossOrigin prop is not required for inputs ([#386](#386)) ([b9e7217](b9e7217)) * **input:** add aria-invalid when an input has an error ([#379](#379)) ([ec26782](ec26782)) * add border secondary ([#355](#355)) ([75243ec](75243ec))
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
In this PR we are adding
aria-invalidto theInputcomponent if there is an error
Why:
This is for better accessibility, currently we can only assert if an input box contains an error through CSS computations, which is not the best practice
How:
Add
aria-invalidiferrorexists
Media:
Checklist: