Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add variants of tag component in Tag and SelectList #372

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Add variants of tag component in Tag and SelectList #372

merged 3 commits into from
Sep 1, 2023

Conversation

hackbnw
Copy link
Contributor

@hackbnw hackbnw commented Aug 30, 2023 •
edited
Loading

What:

Error Variant for Tag and SelectList Options (#354).
​
Why:

We want to highlight certain items to make it clear to the users that those are invalid and they should remove them. Otherwise the configuration will be considered broken.
​
How:

  • Fix missing Open Sans font in storybook
  • Add storybook stories for SelectList with multi select
  • Support new variant = "default" | "disabled" | "error" property in the Tag component
  • Support having "error" property on options of SelectList element to render the entry tag in "error" variant
  • Use semantic colors in accordance with design specification for tags in Tag and SelectList
    ​

Media:

Tag:

default

disabled

error

SelectList:

image

image

Checklist:

  • Ready to be merged

@hackbnw hackbnw changed the title Add variants of tag component in Tag and SelectList (#354) Add variants of tag component in Tag and SelectList Aug 30, 2023
@jahe jahe self-requested a review August 30, 2023 13:07
jahe
jahe approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@jahe jahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nlopin nlopin linked an issue Aug 30, 2023 that may be closed by this pull request
Error Variant for Tag and SelectList Options #354
Closed
@nlopin nlopin mentioned this pull request Aug 30, 2023
Closed
nlopin
nlopin suggested changes Aug 31, 2023
View reviewed changes
src/components/SelectList/SelectList.tsx Outdated Show resolved Hide resolved
src/components/SelectList/SelectList.tsx Outdated Show resolved Hide resolved
src/components/Tag/Tag.tsx Outdated Show resolved Hide resolved
@nlopin nlopin merged commit e0eecdd into freenowtech:main Sep 1, 2023
github-actions bot pushed a commit that referenced this pull request Sep 1, 2023
@semantic-release-bot
chore(release): 1.34.0 [skip ci]
205bb36 
## [1.34.0](v1.33.0...v1.34.0) (2023-09-01)

### Features

* add error Tag and SelectList variants ([#372](#372)) ([e0eecdd](e0eecdd)), closes [#354](#354)
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

🎉 This PR is included in version 1.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hackbnw hackbnw deleted the feature/RP-10976-error-tag branch September 1, 2023 10:56
martimalek added a commit that referenced this pull request Sep 29, 2023
@martimalek @nlopin
@div-Leo @semantic-release-bot @hackbnw @JanHamara @lloydaf
chore: resolve conflicts between next and main (#380)
b011ab0 
* chore: dependency update

* 1.32.2

* fix: add border secondary (#355)

Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>

* chore(release): 1.32.2 [skip ci]

### [1.32.2](v1.32.1...v1.32.2) (2023-08-17)

### Bug Fixes

* add border secondary ([#355](#355)) ([75243ec](75243ec))

* feat: add breadcrumbs component (#353)

* feat: add breadcrumbs component

* feat: add a11y properites

---------

Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>

* chore(release): 1.33.0 [skip ci]

## [1.33.0](v1.32.2...v1.33.0) (2023-08-18)

### Features

* add breadcrumbs component ([#353](#353)) ([ed82e05](ed82e05))

* feat: add error Tag and SelectList variants (#372)

* fix: add Open Sans font to storybook

* feat: add variants of tag component in Tag and SelectList (#354)

* feat: add variants of tag component, resolve comments

---------

Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com>

* chore(release): 1.34.0 [skip ci]

## [1.34.0](v1.33.0...v1.34.0) (2023-09-01)

### Features

* add error Tag and SelectList variants ([#372](#372)) ([e0eecdd](e0eecdd)), closes [#354](#354)

* refactor: replace deprecated weak prop for secondary in text usages (#375)

* refactor: migrate Datepicker to popper positioning engine (#378)

* refactor: migrate Datepicker to popper positioning engine

* build: remove react-tether dependency

* chore: remove unnecessary prop types and use useState directly

* main: export Breadcrumbs component

* 1.34.1

* fix(input): add aria-invalid when an input has an error (#379)

* chore(release): 1.34.1 [skip ci]

### [1.34.1](v1.34.0...v1.34.1) (2023-09-29)

### Bug Fixes

* **input:** add aria-invalid when an input has an error ([#379](#379)) ([ec26782](ec26782))

* chore: ignore codemods tests fixtures when running stylelint

---------

Co-authored-by: Nikolai Lopin <code@lopin.me>
Co-authored-by: Leonardo <leonardo.divittorio@live.it>
Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>
Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Co-authored-by: hackbnw <420178+hackbnw@users.noreply.github.com>
Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com>
Co-authored-by: Jan Hamara <hamara.jan18@gmail.com>
Co-authored-by: Lloyd Francis <lloydaf@gmail.com>
martimalek added a commit that referenced this pull request Feb 2, 2024
@martimalek @nlopin
@div-Leo @semantic-release-bot @hackbnw @JanHamara @lloydaf @arturmiglio
chore: resolve conflicts between main and next (#416)
5212f1b 
* chore: dependency update

* 1.32.2

* fix: add border secondary (#355)

Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>

* chore(release): 1.32.2 [skip ci]

### [1.32.2](v1.32.1...v1.32.2) (2023-08-17)

### Bug Fixes

* add border secondary ([#355](#355)) ([75243ec](75243ec))

* feat: add breadcrumbs component (#353)

* feat: add breadcrumbs component

* feat: add a11y properites

---------

Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>

* chore(release): 1.33.0 [skip ci]

## [1.33.0](v1.32.2...v1.33.0) (2023-08-18)

### Features

* add breadcrumbs component ([#353](#353)) ([ed82e05](ed82e05))

* feat: add error Tag and SelectList variants (#372)

* fix: add Open Sans font to storybook

* feat: add variants of tag component in Tag and SelectList (#354)

* feat: add variants of tag component, resolve comments

---------

Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com>

* chore(release): 1.34.0 [skip ci]

## [1.34.0](v1.33.0...v1.34.0) (2023-09-01)

### Features

* add error Tag and SelectList variants ([#372](#372)) ([e0eecdd](e0eecdd)), closes [#354](#354)

* refactor: replace deprecated weak prop for secondary in text usages (#375)

* refactor: migrate Datepicker to popper positioning engine (#378)

* refactor: migrate Datepicker to popper positioning engine

* build: remove react-tether dependency

* chore: remove unnecessary prop types and use useState directly

* main: export Breadcrumbs component

* 1.34.1

* fix(input): add aria-invalid when an input has an error (#379)

* chore(release): 1.34.1 [skip ci]

### [1.34.1](v1.34.0...v1.34.1) (2023-09-29)

### Bug Fixes

* **input:** add aria-invalid when an input has an error ([#379](#379)) ([ec26782](ec26782))

* fix(deps): crossOrigin prop is not required for inputs (#386)

* chore(deps): move @testing-library/react-hooks to devDependencies

* fix(deps): override @types/react of react-windowed-select to ^17.0.67

* chore(deps): pin @types/react overrides

---------

Co-authored-by: Artur Miglio <arturmiglio@gmail.com>

* chore(release): 1.34.2 [skip ci]

### [1.34.2](v1.34.1...v1.34.2) (2023-10-05)

### Bug Fixes

* **deps:** crossOrigin prop is not required for inputs ([#386](#386)) ([b9e7217](b9e7217))

* fix: enhanced breadcrumbs style (#390)

* fix: enhanced breadcrumbs style

* fix: linting error 0 unit

---------

Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>

* chore(release): 1.34.3 [skip ci]

### [1.34.3](v1.34.2...v1.34.3) (2023-10-11)

### Bug Fixes

* enhanced breadcrumbs style ([#390](#390)) ([e364381](e364381))

* fix(infobanner): allow to override attrs in InfoBannerCard (#393)

* chore(release): 1.34.4 [skip ci]

### [1.34.4](v1.34.3...v1.34.4) (2023-11-03)

### Bug Fixes

* **infobanner:** allow to override attrs in InfoBannerCard ([#393](#393)) ([8b1457e](8b1457e))

* chore: pull request template cleanup

* docs: correct changelog

* docs: minor typo fixes

---------

Co-authored-by: Nikolai Lopin <code@lopin.me>
Co-authored-by: Leonardo <leonardo.divittorio@live.it>
Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>
Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Co-authored-by: hackbnw <420178+hackbnw@users.noreply.github.com>
Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com>
Co-authored-by: Jan Hamara <hamara.jan18@gmail.com>
Co-authored-by: Lloyd Francis <lloydaf@gmail.com>
Co-authored-by: Artur Miglio <arturmiglio@gmail.com>
Co-authored-by: Nikolai Lopin <nikolai.lopin@free-now.com>
github-actions bot pushed a commit that referenced this pull request Feb 2, 2024
@semantic-release-bot
chore(release): 2.1.0 [skip ci]
6d7fefa 
## [2.1.0](v2.0.1...v2.1.0) (2024-02-02)

### Features

* add breadcrumbs component ([#353](#353)) ([ed82e05](ed82e05))
* add error Tag and SelectList variants ([#372](#372)) ([e0eecdd](e0eecdd)), closes [#354](#354)

### Bug Fixes

* **infobanner:** allow to override attrs in InfoBannerCard ([#393](#393)) ([8b1457e](8b1457e))
* enhanced breadcrumbs style ([#390](#390)) ([e364381](e364381))
* **deps:** crossOrigin prop is not required for inputs ([#386](#386)) ([b9e7217](b9e7217))
* **input:** add aria-invalid when an input has an error ([#379](#379)) ([ec26782](ec26782))
* add border secondary ([#355](#355)) ([75243ec](75243ec))
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahe jahe jahe approved these changes

@nlopin nlopin nlopin approved these changes

@martimalek martimalek Awaiting requested review from martimalek

@div-Leo div-Leo Awaiting requested review from div-Leo

@jonotrujillo jonotrujillo Awaiting requested review from jonotrujillo jonotrujillo is a code owner

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error Variant for Tag and SelectList Options
3 participants
@hackbnw @nlopin @jahe