Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace deprecated weak prop for secondary in text usages #375

Merged
merged 1 commit into from
Sep 20, 2023
Merged

refactor: replace deprecated weak prop for secondary in text usages #375

merged 1 commit into from
Sep 20, 2023

Conversation

martimalek
Copy link
Contributor

What:

Replace the deprecated weak prop in favour of secondary in internal usages of the Text component

​
Why:

The weak prop is deprecated so we shouldn't use it, on top of that using it throws a warning which bubbles up to external projects that use Wave components with usages of weak

​
How:

Replace all usages of weak prop of Text components

Checklist:

  • Ready to be merged

Closes #304

@martimalek martimalek requested a review from nlopin as a code owner September 19, 2023 12:06
@martimalek martimalek self-assigned this Sep 19, 2023
@nlopin
Copy link
Contributor

nlopin commented Sep 19, 2023 •
edited
Loading

Let's remove weak from the component code as well

@martimalek
Copy link
Contributor Author

martimalek commented Sep 19, 2023 •
edited
Loading

Let's remove weak from the component code as well

Hey @nlopin, I'm not sure if I follow, I was planning on removing the weak prop altogether in a different PR branching out from next, since the current PR is pointing to main it will be released in the current major and removing weak would be a breaking change, did I misunderstand you?

What I could do is use the same PR for the codemod (#374) to remove the weak prop for instance...

@nlopin
Copy link
Contributor

nlopin commented Sep 20, 2023

Let's remove weak from the component code as well

Hey @nlopin, I'm not sure if I follow, I was planning on removing the weak prop altogether in a different PR branching out from next, since the current PR is pointing to main it will be released in the current major and removing weak would be a breaking change, did I misunderstand you?

What I could do is use the same PR for the codemod (#374) to remove the weak prop for instance...

My bad! it should be removed in the next branch, not main. Codemod PR will do

@martimalek martimalek merged commit 8efebf7 into main Sep 20, 2023
@martimalek martimalek deleted the remove-text-weak-prop-usage branch September 20, 2023 11:42
martimalek added a commit that referenced this pull request Sep 29, 2023
@martimalek @nlopin
@div-Leo @semantic-release-bot @hackbnw @JanHamara @lloydaf
chore: resolve conflicts between next and main (#380)
b011ab0 
* chore: dependency update

* 1.32.2

* fix: add border secondary (#355)

Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>

* chore(release): 1.32.2 [skip ci]

### [1.32.2](v1.32.1...v1.32.2) (2023-08-17)

### Bug Fixes

* add border secondary ([#355](#355)) ([75243ec](75243ec))

* feat: add breadcrumbs component (#353)

* feat: add breadcrumbs component

* feat: add a11y properites

---------

Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>

* chore(release): 1.33.0 [skip ci]

## [1.33.0](v1.32.2...v1.33.0) (2023-08-18)

### Features

* add breadcrumbs component ([#353](#353)) ([ed82e05](ed82e05))

* feat: add error Tag and SelectList variants (#372)

* fix: add Open Sans font to storybook

* feat: add variants of tag component in Tag and SelectList (#354)

* feat: add variants of tag component, resolve comments

---------

Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com>

* chore(release): 1.34.0 [skip ci]

## [1.34.0](v1.33.0...v1.34.0) (2023-09-01)

### Features

* add error Tag and SelectList variants ([#372](#372)) ([e0eecdd](e0eecdd)), closes [#354](#354)

* refactor: replace deprecated weak prop for secondary in text usages (#375)

* refactor: migrate Datepicker to popper positioning engine (#378)

* refactor: migrate Datepicker to popper positioning engine

* build: remove react-tether dependency

* chore: remove unnecessary prop types and use useState directly

* main: export Breadcrumbs component

* 1.34.1

* fix(input): add aria-invalid when an input has an error (#379)

* chore(release): 1.34.1 [skip ci]

### [1.34.1](v1.34.0...v1.34.1) (2023-09-29)

### Bug Fixes

* **input:** add aria-invalid when an input has an error ([#379](#379)) ([ec26782](ec26782))

* chore: ignore codemods tests fixtures when running stylelint

---------

Co-authored-by: Nikolai Lopin <code@lopin.me>
Co-authored-by: Leonardo <leonardo.divittorio@live.it>
Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>
Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Co-authored-by: hackbnw <420178+hackbnw@users.noreply.github.com>
Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com>
Co-authored-by: Jan Hamara <hamara.jan18@gmail.com>
Co-authored-by: Lloyd Francis <lloydaf@gmail.com>
martimalek added a commit that referenced this pull request Feb 2, 2024
@martimalek @nlopin
@div-Leo @semantic-release-bot @hackbnw @JanHamara @lloydaf @arturmiglio
chore: resolve conflicts between main and next (#416)
5212f1b 
* chore: dependency update

* 1.32.2

* fix: add border secondary (#355)

Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>

* chore(release): 1.32.2 [skip ci]

### [1.32.2](v1.32.1...v1.32.2) (2023-08-17)

### Bug Fixes

* add border secondary ([#355](#355)) ([75243ec](75243ec))

* feat: add breadcrumbs component (#353)

* feat: add breadcrumbs component

* feat: add a11y properites

---------

Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>

* chore(release): 1.33.0 [skip ci]

## [1.33.0](v1.32.2...v1.33.0) (2023-08-18)

### Features

* add breadcrumbs component ([#353](#353)) ([ed82e05](ed82e05))

* feat: add error Tag and SelectList variants (#372)

* fix: add Open Sans font to storybook

* feat: add variants of tag component in Tag and SelectList (#354)

* feat: add variants of tag component, resolve comments

---------

Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com>

* chore(release): 1.34.0 [skip ci]

## [1.34.0](v1.33.0...v1.34.0) (2023-09-01)

### Features

* add error Tag and SelectList variants ([#372](#372)) ([e0eecdd](e0eecdd)), closes [#354](#354)

* refactor: replace deprecated weak prop for secondary in text usages (#375)

* refactor: migrate Datepicker to popper positioning engine (#378)

* refactor: migrate Datepicker to popper positioning engine

* build: remove react-tether dependency

* chore: remove unnecessary prop types and use useState directly

* main: export Breadcrumbs component

* 1.34.1

* fix(input): add aria-invalid when an input has an error (#379)

* chore(release): 1.34.1 [skip ci]

### [1.34.1](v1.34.0...v1.34.1) (2023-09-29)

### Bug Fixes

* **input:** add aria-invalid when an input has an error ([#379](#379)) ([ec26782](ec26782))

* fix(deps): crossOrigin prop is not required for inputs (#386)

* chore(deps): move @testing-library/react-hooks to devDependencies

* fix(deps): override @types/react of react-windowed-select to ^17.0.67

* chore(deps): pin @types/react overrides

---------

Co-authored-by: Artur Miglio <arturmiglio@gmail.com>

* chore(release): 1.34.2 [skip ci]

### [1.34.2](v1.34.1...v1.34.2) (2023-10-05)

### Bug Fixes

* **deps:** crossOrigin prop is not required for inputs ([#386](#386)) ([b9e7217](b9e7217))

* fix: enhanced breadcrumbs style (#390)

* fix: enhanced breadcrumbs style

* fix: linting error 0 unit

---------

Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>

* chore(release): 1.34.3 [skip ci]

### [1.34.3](v1.34.2...v1.34.3) (2023-10-11)

### Bug Fixes

* enhanced breadcrumbs style ([#390](#390)) ([e364381](e364381))

* fix(infobanner): allow to override attrs in InfoBannerCard (#393)

* chore(release): 1.34.4 [skip ci]

### [1.34.4](v1.34.3...v1.34.4) (2023-11-03)

### Bug Fixes

* **infobanner:** allow to override attrs in InfoBannerCard ([#393](#393)) ([8b1457e](8b1457e))

* chore: pull request template cleanup

* docs: correct changelog

* docs: minor typo fixes

---------

Co-authored-by: Nikolai Lopin <code@lopin.me>
Co-authored-by: Leonardo <leonardo.divittorio@live.it>
Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>
Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Co-authored-by: hackbnw <420178+hackbnw@users.noreply.github.com>
Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com>
Co-authored-by: Jan Hamara <hamara.jan18@gmail.com>
Co-authored-by: Lloyd Francis <lloydaf@gmail.com>
Co-authored-by: Artur Miglio <arturmiglio@gmail.com>
Co-authored-by: Nikolai Lopin <nikolai.lopin@free-now.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlopin nlopin nlopin approved these changes

@div-Leo div-Leo Awaiting requested review from div-Leo

@jonotrujillo jonotrujillo Awaiting requested review from jonotrujillo jonotrujillo is a code owner

Assignees

@martimalek martimalek

Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove 'weak' prop usages in Wave components
2 participants
@martimalek @nlopin