Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error Variant for Tag and SelectList Options #354

Closed
jahe opened this issue Aug 17, 2023 · 3 comments · Fixed by #372
Closed

Error Variant for Tag and SelectList Options #354

jahe opened this issue Aug 17, 2023 · 3 comments · Fixed by #372
Labels
enhancement New feature or request

Comments

@jahe
Copy link
Contributor

jahe commented Aug 17, 2023 •
edited
Loading

Hello 👋

As part of RP-10976 we would like to add a new variant for "error" state to the Tag and the SelectList components in wave. The design in figma is ready.

Proposed Changes

  • Add new prop "variant" to Tag component (see code, see example) and apply the styles accordingly (see code)
  • Apply custom styles for SelectList option by adjusting StylesConfig (see code)
@jahe
Copy link
Contributor Author

jahe commented Aug 17, 2023

Examples

image
image

@jahe jahe changed the title Invalid State for Tag and SelectList Options Error Variant for Tag and SelectList Options Aug 17, 2023
@arturmiglio arturmiglio added the enhancement New feature or request label Aug 18, 2023
@nlopin
Copy link
Contributor

nlopin commented Aug 22, 2023

@jahe could you clarify this task a bit? Without the context, It looks like we shouldn't allow the user to select an error option

@jahe
Copy link
Contributor Author

jahe commented Aug 22, 2023

@nlopin We want to highlight certain items to make it clear to the users that those are invalid and they should remove them. Otherwise the configuration will be considered broken.

In our use case it can happen that a certain set of items get invalid after they were created.

Does that clarify things?

hackbnw pushed a commit to hackbnw/wave that referenced this issue Aug 30, 2023
feat: add variants of tag component in Tag and SelectList (freenowtec…
97e8794 
…h#354)
@hackbnw hackbnw mentioned this issue Aug 30, 2023
Merged
1 task
@nlopin nlopin linked a pull request Aug 30, 2023 that will close this issue
Add variants of tag component in Tag and SelectList #372
Merged
1 task
nlopin pushed a commit that referenced this issue Sep 1, 2023
@hackbnw
feat: add error Tag and SelectList variants (#372)
e0eecdd 
* fix: add Open Sans font to storybook

* feat: add variants of tag component in Tag and SelectList (#354)

* feat: add variants of tag component, resolve comments

---------

Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com>
github-actions bot pushed a commit that referenced this issue Sep 1, 2023
@semantic-release-bot
chore(release): 1.34.0 [skip ci]
205bb36 
## [1.34.0](v1.33.0...v1.34.0) (2023-09-01)

### Features

* add error Tag and SelectList variants ([#372](#372)) ([e0eecdd](e0eecdd)), closes [#354](#354)
martimalek added a commit that referenced this issue Sep 29, 2023
@martimalek @nlopin
@div-Leo @semantic-release-bot @hackbnw @JanHamara @lloydaf
chore: resolve conflicts between next and main (#380)
b011ab0 
* chore: dependency update

* 1.32.2

* fix: add border secondary (#355)

Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>

* chore(release): 1.32.2 [skip ci]

### [1.32.2](v1.32.1...v1.32.2) (2023-08-17)

### Bug Fixes

* add border secondary ([#355](#355)) ([75243ec](75243ec))

* feat: add breadcrumbs component (#353)

* feat: add breadcrumbs component

* feat: add a11y properites

---------

Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>

* chore(release): 1.33.0 [skip ci]

## [1.33.0](v1.32.2...v1.33.0) (2023-08-18)

### Features

* add breadcrumbs component ([#353](#353)) ([ed82e05](ed82e05))

* feat: add error Tag and SelectList variants (#372)

* fix: add Open Sans font to storybook

* feat: add variants of tag component in Tag and SelectList (#354)

* feat: add variants of tag component, resolve comments

---------

Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com>

* chore(release): 1.34.0 [skip ci]

## [1.34.0](v1.33.0...v1.34.0) (2023-09-01)

### Features

* add error Tag and SelectList variants ([#372](#372)) ([e0eecdd](e0eecdd)), closes [#354](#354)

* refactor: replace deprecated weak prop for secondary in text usages (#375)

* refactor: migrate Datepicker to popper positioning engine (#378)

* refactor: migrate Datepicker to popper positioning engine

* build: remove react-tether dependency

* chore: remove unnecessary prop types and use useState directly

* main: export Breadcrumbs component

* 1.34.1

* fix(input): add aria-invalid when an input has an error (#379)

* chore(release): 1.34.1 [skip ci]

### [1.34.1](v1.34.0...v1.34.1) (2023-09-29)

### Bug Fixes

* **input:** add aria-invalid when an input has an error ([#379](#379)) ([ec26782](ec26782))

* chore: ignore codemods tests fixtures when running stylelint

---------

Co-authored-by: Nikolai Lopin <code@lopin.me>
Co-authored-by: Leonardo <leonardo.divittorio@live.it>
Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>
Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Co-authored-by: hackbnw <420178+hackbnw@users.noreply.github.com>
Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com>
Co-authored-by: Jan Hamara <hamara.jan18@gmail.com>
Co-authored-by: Lloyd Francis <lloydaf@gmail.com>
martimalek added a commit that referenced this issue Feb 2, 2024
@martimalek @nlopin
@div-Leo @semantic-release-bot @hackbnw @JanHamara @lloydaf @arturmiglio
chore: resolve conflicts between main and next (#416)
5212f1b 
* chore: dependency update

* 1.32.2

* fix: add border secondary (#355)

Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>

* chore(release): 1.32.2 [skip ci]

### [1.32.2](v1.32.1...v1.32.2) (2023-08-17)

### Bug Fixes

* add border secondary ([#355](#355)) ([75243ec](75243ec))

* feat: add breadcrumbs component (#353)

* feat: add breadcrumbs component

* feat: add a11y properites

---------

Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>

* chore(release): 1.33.0 [skip ci]

## [1.33.0](v1.32.2...v1.33.0) (2023-08-18)

### Features

* add breadcrumbs component ([#353](#353)) ([ed82e05](ed82e05))

* feat: add error Tag and SelectList variants (#372)

* fix: add Open Sans font to storybook

* feat: add variants of tag component in Tag and SelectList (#354)

* feat: add variants of tag component, resolve comments

---------

Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com>

* chore(release): 1.34.0 [skip ci]

## [1.34.0](v1.33.0...v1.34.0) (2023-09-01)

### Features

* add error Tag and SelectList variants ([#372](#372)) ([e0eecdd](e0eecdd)), closes [#354](#354)

* refactor: replace deprecated weak prop for secondary in text usages (#375)

* refactor: migrate Datepicker to popper positioning engine (#378)

* refactor: migrate Datepicker to popper positioning engine

* build: remove react-tether dependency

* chore: remove unnecessary prop types and use useState directly

* main: export Breadcrumbs component

* 1.34.1

* fix(input): add aria-invalid when an input has an error (#379)

* chore(release): 1.34.1 [skip ci]

### [1.34.1](v1.34.0...v1.34.1) (2023-09-29)

### Bug Fixes

* **input:** add aria-invalid when an input has an error ([#379](#379)) ([ec26782](ec26782))

* fix(deps): crossOrigin prop is not required for inputs (#386)

* chore(deps): move @testing-library/react-hooks to devDependencies

* fix(deps): override @types/react of react-windowed-select to ^17.0.67

* chore(deps): pin @types/react overrides

---------

Co-authored-by: Artur Miglio <arturmiglio@gmail.com>

* chore(release): 1.34.2 [skip ci]

### [1.34.2](v1.34.1...v1.34.2) (2023-10-05)

### Bug Fixes

* **deps:** crossOrigin prop is not required for inputs ([#386](#386)) ([b9e7217](b9e7217))

* fix: enhanced breadcrumbs style (#390)

* fix: enhanced breadcrumbs style

* fix: linting error 0 unit

---------

Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>

* chore(release): 1.34.3 [skip ci]

### [1.34.3](v1.34.2...v1.34.3) (2023-10-11)

### Bug Fixes

* enhanced breadcrumbs style ([#390](#390)) ([e364381](e364381))

* fix(infobanner): allow to override attrs in InfoBannerCard (#393)

* chore(release): 1.34.4 [skip ci]

### [1.34.4](v1.34.3...v1.34.4) (2023-11-03)

### Bug Fixes

* **infobanner:** allow to override attrs in InfoBannerCard ([#393](#393)) ([8b1457e](8b1457e))

* chore: pull request template cleanup

* docs: correct changelog

* docs: minor typo fixes

---------

Co-authored-by: Nikolai Lopin <code@lopin.me>
Co-authored-by: Leonardo <leonardo.divittorio@live.it>
Co-authored-by: Leonardo Di Vittorio <leonardo.divittorio@Leonardos-MacBook-Pro.local>
Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Co-authored-by: hackbnw <420178+hackbnw@users.noreply.github.com>
Co-authored-by: Yurii Pavlovskyi <yurii.pavlovskyi@free-now.com>
Co-authored-by: Jan Hamara <hamara.jan18@gmail.com>
Co-authored-by: Lloyd Francis <lloydaf@gmail.com>
Co-authored-by: Artur Miglio <arturmiglio@gmail.com>
Co-authored-by: Nikolai Lopin <nikolai.lopin@free-now.com>
github-actions bot pushed a commit that referenced this issue Feb 2, 2024
@semantic-release-bot
chore(release): 2.1.0 [skip ci]
6d7fefa 
## [2.1.0](v2.0.1...v2.1.0) (2024-02-02)

### Features

* add breadcrumbs component ([#353](#353)) ([ed82e05](ed82e05))
* add error Tag and SelectList variants ([#372](#372)) ([e0eecdd](e0eecdd)), closes [#354](#354)

### Bug Fixes

* **infobanner:** allow to override attrs in InfoBannerCard ([#393](#393)) ([8b1457e](8b1457e))
* enhanced breadcrumbs style ([#390](#390)) ([e364381](e364381))
* **deps:** crossOrigin prop is not required for inputs ([#386](#386)) ([b9e7217](b9e7217))
* **input:** add aria-invalid when an input has an error ([#379](#379)) ([ec26782](ec26782))
* add border secondary ([#355](#355)) ([75243ec](75243ec))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add variants of tag component in Tag and SelectList hackbnw/wave
3 participants
@arturmiglio @nlopin @jahe