-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exceptions: evaluate needed exceptions in upstream #176
Comments
FWIW I would just skip tracking/looking into this. Every exception we throw today needs to be caught somewhere and I don't think we are going to reasonably be able to do anything major here. I think our time is better spent elsewhere. |
Sounds like a dead end then. So if that's the case I'm ok not tracking/working on it |
coming back to this (thanks @Reflejo for the magic -fno-unwind-tables -fno-exceptions) it's still a pretty big gain to build without exceptions. From cce99bf8b0 -rwxr-x--- 1 alyssar primarygroup 18953104 Mar 14 09:40 bazel-bin/test/performance/test_binary_size_stripped -rwxr-x--- 1 alyssar primarygroup 17513048 Mar 14 09:37 bazel-bin/test/performance/test_binary_size_stripped |
In my working PR I largely replace throw with throwEnvoyExceptionOrPanic which would be defined to PANIC for E-M on start-up we already catch all exceptions and replace with panic. sans-XDS, any other exceptions would be on the data plane which is disallowed and theoretically doesn't happen. The big gotcha here, is that jbeder_yaml_cpp also has exceptions which means loadFromYaml and friends don't work. Google was already hoping to move away from yaml for E-M since udp doens't support yaml loading, so I'd say that's a prereq for this reduction. |
Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a part of envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a part of envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
running PR here: https://github.com/envoyproxy/envoy/compare/main...alyssawilk:envoy:size_exceptions?expand=1 |
…7754) Risk Level: low Testing: existing tests Docs Changes: n/a Release Notes: n/a Part of envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Commit Message: Additional Description: Risk Level: Testing: Docs Changes: Release Notes: envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Risk Level: low Testing: updated tests Docs Changes: n/a Release Notes: n/a envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Risk Level: low Testing: updated tests Docs Changes: n/a Release Notes: n/a envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Risk Level: low Testing: updated tests Docs Changes: n/a Release Notes: n/a envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Risk Level: low Testing: updated tests Docs Changes: n/a Release Notes: n/a envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Risk Level: low Testing: updated tests Docs Changes: n/a Release Notes: n/a envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Risk Level: low Testing: updated tests Docs Changes: n/a Release Notes: n/a envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Risk Level: low Testing: updated tests Docs Changes: n/a Release Notes: n/a envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Risk Level: low Testing: updated tests Docs Changes: n/a Release Notes: n/a envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Risk Level: low Testing: updated tests Docs Changes: n/a Release Notes: n/a envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Risk Level: low Testing: updated tests Docs Changes: n/a Release Notes: n/a envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Risk Level: low Testing: updated tests Docs Changes: n/a Release Notes: n/a envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Risk Level: low Testing: updated tests Docs Changes: n/a Release Notes: n/a envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Risk Level: low Testing: updated tests Docs Changes: n/a Release Notes: n/a envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Risk Level: low Testing: updated tests Docs Changes: n/a Release Notes: n/a envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Risk Level: low Testing: updated tests Docs Changes: n/a Release Notes: n/a envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Risk Level: low Testing: updated tests Docs Changes: n/a Release Notes: n/a envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Dario Cillerai <dcillera@redhat.com>
This is largely a more speculative issue. According to analysis of sections within compilation units, most source files end up having a not insignificant size proportion in exception tables. @Reflejo recommended analyzing cases where exceptions might lead to irrecoverable conditions.
Size Win
per #17 (comment)
The text was updated successfully, but these errors were encountered: