Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validator: allowing creation failure #37456

Merged
merged 1 commit into from
Dec 4, 2024
Merged

validator: allowing creation failure #37456

merged 1 commit into from
Dec 4, 2024

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented Dec 2, 2024 •
edited
Loading

Risk Level: low
Testing: updated tests
Docs Changes: n/a
Release Notes: n/a
envoyproxy/envoy-mobile#176

@alyssawilk
validator: allowing creation failure
e06e1da 
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@repokitteh-read-only RepoKitteh - Read Only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #37456 was opened by alyssawilk.

see: more, trace.

@alyssawilk alyssawilk marked this pull request as ready for review December 2, 2024 17:58
@yanavlasov yanavlasov merged commit 4ecda60 into envoyproxy:main Dec 4, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanavlasov yanavlasov yanavlasov approved these changes

@RyanTheOptimist RyanTheOptimist Awaiting requested review from RyanTheOptimist RyanTheOptimist is a code owner

@abeyad abeyad Awaiting requested review from abeyad abeyad is a code owner

@fredyw fredyw Awaiting requested review from fredyw fredyw is a code owner

@botengyao botengyao Awaiting requested review from botengyao botengyao is a code owner

@tyxia tyxia Awaiting requested review from tyxia tyxia is a code owner

Assignees

@yanavlasov yanavlasov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alyssawilk @yanavlasov