http: moving exceptions out of http_server_properties_cache_manager_impl #27829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
/retest |
RyanTheOptimist
approved these changes
Jun 7, 2023
| @@ -38,6 +38,7 @@ Filter::Filter(const FilterConfigSharedPtr& config, Event::Dispatcher& dispatche | |||
| : cache_(config->getAlternateProtocolCache(dispatcher)), time_source_(config->timeSource()) {} | |||
|
|
|||
| Http::FilterHeadersStatus Filter::encodeHeaders(Http::ResponseHeaderMap& headers, bool) { | |||
|
|
|||
There was a problem hiding this comment.
Given I've got another PR in this space and github is broken I'll do in my follow up :-)
| @@ -131,7 +131,6 @@ paths: | |||
| - source/common/http/filter_chain_helper.h | |||
| - source/common/http/conn_manager_utility.cc | |||
| - source/common/http/match_delegate/config.cc | |||
| - source/common/http/http_server_properties_cache_manager_impl.cc | |||
asheryerm
pushed a commit
to asheryerm/envoy
that referenced
this pull request
Jul 5, 2023
…mpl (envoyproxy#27829) Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: asheryer <asheryer@amazon.com>
reskin89
pushed a commit
to reskin89/envoy
that referenced
this pull request
Jul 11, 2023
…mpl (envoyproxy#27829) Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
part of envoyproxy/envoy-mobile#176