Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns_cache: removing exceptions #37499

Merged
merged 1 commit into from
Dec 4, 2024
Merged

dns_cache: removing exceptions #37499

merged 1 commit into from
Dec 4, 2024

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented Dec 4, 2024 •
edited
Loading

Risk Level: low
Testing: updated tests
Docs Changes: n/a
Release Notes: n/a
envoyproxy/envoy-mobile#176

@alyssawilk
dfp: removing exceptions
d9c2131 
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@repokitteh-read-only RepoKitteh - Read Only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #37499 was opened by alyssawilk.

see: more, trace.

@alyssawilk alyssawilk changed the title dfp: removing exceptions dns_cache: removing exceptions Dec 4, 2024
@alyssawilk alyssawilk marked this pull request as ready for review December 4, 2024 20:02
@alyssawilk alyssawilk enabled auto-merge (squash) December 4, 2024 20:02
botengyao
botengyao approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@botengyao botengyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@alyssawilk alyssawilk merged commit 144f4dc into envoyproxy:main Dec 4, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@botengyao botengyao botengyao approved these changes

@mattklein123 mattklein123 Awaiting requested review from mattklein123 mattklein123 is a code owner

Assignees

@botengyao botengyao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alyssawilk @botengyao