api listener: removing exceptions #27824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
requested review from
RyanTheOptimist,
abeyad and
htuch
as code owners
abeyad
previously approved these changes
Jun 7, 2023
envoy/server/listener_manager.h
Outdated
| * a duplicate of the existing listener. This routine will throw an EnvoyException if | ||
| * there is a fundamental error preventing the listener from being added or updated. | ||
| * a duplicate of the existing listener. This routine will return | ||
| * absl::InvalidArgumentError if there is a fundamental error preventing the listener from being |
There was a problem hiding this comment.
the alignment here is a bit off, should line up with previous line
|
/retest |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
abeyad
approved these changes
Jun 7, 2023
|
/retest |
2 similar comments
|
/retest |
|
/retest |
asheryerm
pushed a commit
to asheryerm/envoy
that referenced
this pull request
Jul 5, 2023
Commit Message: Additional Description: Risk Level: Testing: Docs Changes: Release Notes: envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: asheryer <asheryer@amazon.com>
reskin89
pushed a commit
to reskin89/envoy
that referenced
this pull request
Jul 11, 2023
Commit Message: Additional Description: Risk Level: Testing: Docs Changes: Release Notes: envoyproxy/envoy-mobile#176 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
envoyproxy/envoy-mobile#176