Ember 3.0 Related Cleanup

[rwjblue]

• Remove phantomjs usage from CI (tracking in Run tests with Chrome headless. #15877)
• Remove IE9 and IE10 from CI runs. (tracking in Remove IE9 and IE10 from CI. #15879)
• Leverage native WeakMaps 🔒 @sivakumar-kailasam Leverage native WeakMaps #15878
  • Remove packages/ember-utils/lib/weak-map-utils.js
  • Remove non-WeakMap fallback in packages/ember-metal/lib/meta.js here
  • Remove non-WeakMap fallbacks in packages/ember-metal/lib/transaction.js
  • Remove non-WeakMap fallback in packages/ember-glimmer/lib/utils/references.ts here
  • Remove packages/ember-metal/lib/weak_map.js
• Remove custom Map from packages/ember-metal/lib/map.js (being tracked in Map and MapWithDefault marked as private #13815) 🔒 @maxwerr
• Remove console polyfills / shims in packages/ember-console/lib/index.js Removed console polyfills/shims #15881
• phantomjs support / hacks [CLEANUP] Remove phantomjs hacks, docs & scripts #15880
  • Remove isPhantom flag from packages/ember-environment/lib/index.js
  • Remove workarounds for phantoms broken define property in packages/ember-metal/lib/properties.js (here, here, and here)
• Deprecations labeled until: '3.0.0' - These need to be extracted (when possible) and behind an ENV flag when extraction is not possible. We will enable usage of these deprecated features through Ember 3.4 when using the 3.0 legacy addon. 🔒 @thoov while we setup the legacy addon infrastructure...
  • (:lock: @thoov) didInitAttrs (here, here, and here)
  • Ember.observer(callback, 'dependent-key1', 'dependent-key2') here (being worked on in [CLEANUP] removed providing reversed arguments to observer #15893)
  • this.resource in Router.map DSL here (tracking in Remove this.resource from RouterDSL #15883)
  • fooBinding support
    • packages/ember-metal/lib/binding.js
    • packages/ember-template-compiler/lib/plugins/transform-old-binding-syntax.js
    • packages/ember-metal/lib/mixin.js here and here
    • packages/ember-runtime/lib/system/core_object.js here and here
    • packages/ember-metal/lib/meta.js here and here
  • (🔒 @gowthamrm) Providing resolver as a function to the registry. here and here
  • immediateObserver here and here (being worked on in [CLEANUP] removed immediateObserver #15894)
  • Enumerable#contains here (being addressed in [CLEANUP] Remove Enumerable#contains #15889)
  • (:lock: @bekzod) Transforming {{input on="enter" action="foo"}} to {{input enter="foo"}} in packages/ember-template-compiler/lib/plugins/transform-input-on-to-onEvent.js, also here and here
  • EMBER_GLIMMER_ALLOW_BACKTRACKING_RERENDER feature flag (this can be removed without flagging/guarding as it was never enabled) (tracking in Remove EMBER_GLIMMER_ALLOW_BACKTRACKING_RERENDER feature flag #15890)
  • link-to's currentWhen here (being addressed in [DOC release] Fix current-when name in documentation #15885)
  • Ember.String.fmt here 🔒ed by @locks (tracking in Remove Ember.String.fmt #15882)
  • models wrapped in controllers for link-to here (being addressed by [CLEANUP] Remove controller wrapped param deprecation #15897)
  • (:lock: @thoov) _actions
    • packages/ember-runtime/lib/mixins/action_handler.js here
    • packages/ember-routing/lib/system/route.js here
    • packages/ember-runtime/lib/controllers/controller.js here
    • packages/ember-views/lib/views/core_view.js here
    • packages/ember-runtime/lib/index.js here
  • (:lock: @thoov) Legacy controller proxying behaviors (can be removed completely, until was incorrect) here and here
  • Ember.Freezable packages/ember-runtime/lib/mixins/freezable.js and here (being addressed in [CLEANUP] remove Freezable #15891)
  • (:lock: @thoov) {{render
    • {{render 'foo' someArg}} - packages/ember-template-compiler/lib/plugins/deprecate-render-model.js
    • {{render 'foo'}} - packages/ember-template-compiler/lib/plugins/deprecate-render.js
    • Render component manager - packages/ember-glimmer/lib/component-managers/render.ts
    • {{render syntax - packages/ember-glimmer/lib/syntax/render.ts and here
  • Ember.REQUIRED here and here (being addressed by [CLEANUP] removed Ember.required #15892)
  • {Application,Engine,ApplicationInstance}.registry support here, here, and here
  • Arity check for initializers here (being addressed in Remove arity check from initializer #15886)
  • Orphaned outlets here, here, and here
  • Ember.Component#defaultLayout here (addressed in [CLEANUP] Remove Ember.Component#defaultLayout #15896)
  • Ember.Handlebars.SafeString here and here (addressed in [CLEANUP] Remove Ember.Handlebars.SafeString #15901)
  • Ember.deprecate signature - these deprecations should be changed to assertions (addressed by [CLEANUP] Remove deprecate checks inside of Ember.deprecate #15903)
  • Ember.warn signature - these deprecations should be changed to assertions [CLEANUP] Change warn deprecations to asserts #15900
  • Ember.K here

---

To pick up one of these items, please comment below and we'll update the checklist with :lock: @your-name-here...

[sivakumar-kailasam]

@rwjblue Should Ember.WeakMap be removed too?

[rwjblue]

@rwjblue Should Ember.WeakMap be removed too?

I believe it is on the list above, under Remove 'packages/ember-metal/lib/weak_map.js'

[thoov]

If they haven't been taken I can start off with working on the Leverage native WeakMaps and all of the sub tasks for this

[rwjblue]

@thoov - Some are being tackled by @sivakumar-kailasam in #15878, can you take a look at that PR to help review (and determine what I've missed...)?

[thoov]

@rwjblue I will help with the review of that. I will change up my tactic and take the bottom 4 off of the list then.

[rwjblue]

@thoov - Sounds good! I have updated the items and marked the whole Deprecations subsection as 🔒ed, because we will need to create the legacy support addon and ENV flag infrastructure (so any one else working on deprecations will be blocked anyways).

[t-sauer]

I'd like to work on 'phantomjs support / hacks' if that is still up for grabs

[sivakumar-kailasam]

@t-sauer I'm ready to raise a PR for that 😅

[t-sauer]

Well then I'll pick "Remove console polyfills / shims in packages/ember-console/lib/index.js" 🤞

[maxscott]

Ill take a stab at Remove custom Map from packages/ember-metal/lib/map.js

[locks]

Taking Ember.String.fmt: #15882.

[locks]

Taking this.resource on RouterDSL: #15883.

[locks]

Taking link-to's currentWhen: #15884.

[locks]

Taking "Arity check for initializers": #15886.

[rwjblue]

@locks one thing to keep in mind, is that we can't remove the functionality completely just yet. We have to either add it to https://github.com/emberjs/ember-2-legacy or wrap it in a conditional flag.

This is due to our stated goal from the 3.0 blog post:

To further expand the migration window for 2.x applications to adopt 3.x, we will be releasing an addon that provides support for Ember.js 2.x APIs into the 3.x series. We’re committing to support that addon until Ember 3.4 (the first LTS candidate of the Ember 3.x cycle). If you want to contribute to this effort, you can find this package under the name ember-2-legacy.

[locks]

@rwjblue roger that 👍 I will review per-feature what the best approach might be. I'm partial to moving the implementation to the legacy addon if possible, if nothing else it seems neater.

[rwjblue]

Absolutely agreed! We just need to ensure we have a path forward. Things like fooBinding support will almost certainly have to be wrapped in conditionals here. But things like Ember.String.fmt and link-to currentWhen can totally be done in the addon itself directly.

[cibernox]

Enumerable#contains
#15889

[bekzod]

Taking Ember.Freezable #15891

[bekzod]

Taking Ember.REQUIRED #15892

[bekzod]

Taking Ember.observer(callback, 'dependent-key1', 'dependent-key2') #15893

[bekzod]

Taking immediateObserver #15894

[thoov]

@rwjblue Lock me up on:

Ember.Component#defaultLayout
_actions
render
Legacy controller proxying behaviors
didInit

[rwjblue]

@thoov - Done (but defaultLayout was already taken by @romulomachado in #15896)

[rwjblue]

I believe I have everything triaged, please ping me (probably in #dev-ember in slack) if I've missed something...

[bekzod]

Taking Transforming {{input on="enter" action="foo"}} to {{input enter="foo"}} #15910

[cibernox]

Is there anything not claimed? It seems that fooBinding is free

[cibernox]

I take {Application,Engine,ApplicationInstance}.registry

[gowthamrm]

Taking Providing resolver as a function to the registry

Fixed in #15911

[lorcan]

I took a stab at Orphaned outlets here, here, and here: #15916

[alexander-alvarez]

@rwjblue we need to update the testing blueprints... not sure if this is explicitly 3.0 related

[rwjblue]

@alexander-alvarez - You are absolutely right! I will try to get another quest issue together for the blueprints in the next day or so...