[CLEANUP] Remove legacy controller proxy behavior #15922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
reviewed
Dec 7, 2017
| `You attempted to access \`${key}\` from \`${this}\`, but object proxying is deprecated. Please use \`model.${key}\` instead.`, | ||
| !this.isController, | ||
| { id: 'ember-runtime.controller-proxy', until: '3.0.0' } | ||
| ); | ||
| return get(content, key); | ||
| } |
There was a problem hiding this comment.
@rwjblue shouldn't we remove the remaining code too instead of removing just the deprecation warning?
There was a problem hiding this comment.
@Turbo87 What do you mean by remaining code?
There was a problem hiding this comment.
the return get(content, key); 🤔
There was a problem hiding this comment.
No, that code supports proxies generally. The deprecation was only for when a Ember.Controller base class mixed in the proxy mixin (which is how Ember.ObjectController and Ember.ArrayController worked). Those two classes have been removed, and this mixin is private so there was just no need for the deprecation for when included in controllers...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart of: #15876