Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove arity check from initializer #15886

Merged
merged 1 commit into from
Dec 20, 2017
Merged

Remove arity check from initializer #15886

merged 1 commit into from
Dec 20, 2017

Conversation

locks
Copy link
Contributor

@locks locks commented Nov 29, 2017

No description provided.

@locks locks mentioned this pull request Nov 29, 2017
Closed
34 tasks
rwjblue
rwjblue reviewed Nov 29, 2017
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the legacy addon can monkey patch via Ember.Engine.reopen({ runInitializers() { }}), I think this can safely be moved into the legacy addon.

Can you create an issue over there, and cross link back here?

@locks locks mentioned this pull request Nov 29, 2017
Closed
@thoov thoov mentioned this pull request Dec 12, 2017
Merged
@rwjblue
Copy link
Member

rwjblue commented Dec 13, 2017

@locks - Ping!

@thoov
Copy link
Member

thoov commented Dec 19, 2017 •
edited
Loading

LGTM 🚢 (pending build passing)

@locks locks force-pushed the remove-initializer-arity-check branch 2 times, most recently from 73b76d6 to 335f7f0 Compare December 20, 2017 11:33
@locks locks force-pushed the remove-initializer-arity-check branch from 335f7f0 to 40bc56c Compare December 20, 2017 11:34
@locks
Copy link
Contributor Author

locks commented Dec 20, 2017

Finally green :)

@rwjblue rwjblue merged commit 71b688a into master Dec 20, 2017
@mixonic mixonic deleted the remove-initializer-arity-check branch January 1, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@locks @rwjblue @thoov